Skip to content

[ALICE3] A3RICH: Linter fixes #12038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 9 commits into from
Jul 14, 2025
Merged

[ALICE3] A3RICH: Linter fixes #12038

njacazio merged 9 commits into from
Jul 14, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jul 13, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 13, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update onTheFlyRichPid.cxx [ALICE3] Update onTheFlyRichPid.cxx Jul 13, 2025
@njacazio njacazio changed the title [ALICE3] Update onTheFlyRichPid.cxx [ALICE3] A3RICH: Linter fixes Jul 13, 2025
@njacazio
Copy link
Collaborator Author

njacazio commented Jul 13, 2025

Comes after #12037

@alibuild alibuild mentioned this pull request Jul 13, 2025
Closed
@njacazio njacazio marked this pull request as ready for review July 13, 2025 21:19
@njacazio njacazio enabled auto-merge (squash) July 13, 2025 21:20
alibuild
alibuild previously approved these changes Jul 13, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild
Copy link
Collaborator

alibuild commented Jul 13, 2025

Error while checking build/O2Physics/o2 for 72e92a9 at 2025-07-14 01:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12038-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRichPid.cxx:664:17: error: redeclaration of 'const float n0'
/sw/SOURCES/O2Physics/12038-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRichPid.cxx:938:28: error: 'kka' was not declared in this scope; did you mean 'kKa'?
ninja: build stopped: subcommand failed.


## sw/BUILD/3d9f96f30fd85aeeae341bb904db6819816d3ae6-latest/log
/sw/SOURCES/O2Physics/12038-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRichPid.cxx:664:17: error: redeclaration of 'const float n0'
/sw/SOURCES/O2Physics/12038-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRichPid.cxx:938:28: error: 'kka' was not declared in this scope; did you mean 'kKa'?
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio requested a review from alibuild July 14, 2025 04:36
@njacazio njacazio disabled auto-merge July 14, 2025 09:00
@njacazio njacazio enabled auto-merge (squash) July 14, 2025 09:00
alibuild
alibuild approved these changes Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit a578a67 into master Jul 14, 2025
14 checks passed
@njacazio njacazio deleted the njacazio-patch-6 branch July 14, 2025 09:00
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@njacazio @jpxrk
[ALICE3] A3RICH: Linter fixes (AliceO2Group#12038)
02bcd8c
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@njacazio
[ALICE3] A3RICH: Linter fixes (AliceO2Group#12038)
3dfa2ab
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@njacazio
[ALICE3] A3RICH: Linter fixes (AliceO2Group#12038)
5a52468
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@njacazio @vojmach
[ALICE3] A3RICH: Linter fixes (AliceO2Group#12038)
0207654
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@njacazio @jloemker
[ALICE3] A3RICH: Linter fixes (AliceO2Group#12038)
9e6e5a1
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@njacazio
[ALICE3] A3RICH: Linter fixes (AliceO2Group#12038)
5314fa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild