Skip to content

Conversation

@gianniliveraro
Copy link
Contributor

This PR introduces a new task (sigma0QC) to evaluate the performance of different V0 grouping strategies in O2Physics using strangeness derived data.

It enables a direct comparison between four grouping approaches:

  • Grouping via collision iterator;

  • Grouping using Preslice;

  • Grouping using PresliceUnsorted;

  • Custom grouping using a simple std::vector<std::vector<>>.

Each approach is implemented in a separate struct. The base template, defined in "sigma0BuilderHelper.h", follows the logic of the sigma0builder task: V0s are grouped per collision, filtered using photon- and lambda-like criteria, and combined to build Sigma0 candidates.

Additionally, this PR also updates the sigma0builder task to adopt the custom grouping strategy for analysis.

Tagging @ddobrigk and @romainschotter for completeness.

@github-actions
Copy link

github-actions bot commented Jul 11, 2025

O2 linter results: ❌ 298 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#12027
romainschotter
romainschotter previously approved these changes Jul 11, 2025
@romainschotter romainschotter enabled auto-merge (squash) July 11, 2025 17:40
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 242f55c at 2025-07-11 20:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:240:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:241:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:242:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:265:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:321:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:352:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:383:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:384:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:409:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:410:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:411:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:416:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:421:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:422:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:240:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:241:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:242:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:352:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:383:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:384:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:265:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:321:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:409:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:410:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:411:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:416:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:421:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:422:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:352:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:383:34: error: 'HIST' was not declared in this scope
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:384:34: error: 'HIST' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
ninja: build stopped: subcommand failed.


## sw/BUILD/d1c8b1adec849ed919b430bba044773712d42c70-latest/log
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:240:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:241:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:242:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:265:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:321:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:352:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:383:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:384:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:409:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:410:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:411:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:416:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
/sw/SOURCES/O2Physics/12027-slc9_x86-64/0/PWGLF/Utils/sigma0BuilderHelper.h:421:30: error: there are no arguments to 'HIST' that depend on a template parameter, so a declaration of 'HIST' must be available [-fpermissive]
[0 more errors; see full log]

Full log here.

@ddobrigk
Copy link
Collaborator

O2 compile error is spurious (from before the fix), newest O2 CI should work

auto-merge was automatically disabled July 13, 2025 13:49

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants