-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGLF] Add QC task for grouping tests + update sigma0builder #12027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 298 errors, |
Please consider the following formatting changes to AliceO2Group#12027
romainschotter
previously approved these changes
Jul 11, 2025
Collaborator
|
Error while checking build/O2Physics/o2 for 242f55c at 2025-07-11 20:56: Full log here. |
Collaborator
|
O2 compile error is spurious (from before the fix), newest O2 CI should work |
romainschotter
approved these changes
Jul 11, 2025
auto-merge was automatically disabled
July 13, 2025 13:49
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new task (sigma0QC) to evaluate the performance of different V0 grouping strategies in O2Physics using strangeness derived data.
It enables a direct comparison between four grouping approaches:
Grouping via collision iterator;
Grouping using Preslice;
Grouping using PresliceUnsorted;
Custom grouping using a simple std::vector<std::vector<>>.
Each approach is implemented in a separate struct. The base template, defined in "sigma0BuilderHelper.h", follows the logic of the sigma0builder task: V0s are grouped per collision, filtered using photon- and lambda-like criteria, and combined to build Sigma0 candidates.
Additionally, this PR also updates the sigma0builder task to adopt the custom grouping strategy for analysis.
Tagging @ddobrigk and @romainschotter for completeness.