Skip to content

Conversation

@pstahlhu
Copy link
Contributor

@pstahlhu pstahlhu commented Jul 9, 2025

@JaeYoonCHO @sh-lim @klsmith15k

  • Add $\Sigma p_{\rm{T}}(\pi\leftarrow\Xi_{c}^{+})$ cut
  • Add QA histograms for daughter track properties to candidate selector: $\eta$, TPC clusters and crossed rows of all final state daughter particles; ITS clusters of $\pi$ from $\Xi_{c}^{+}$
  • Improve counter histogram filling conditions
  • Fill counter histograms in candidate creator and selector by default, and make filling of other histograms configurable

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments from my side!

}

// add histograms to registry
registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1F, {{2, -0.5, 1.5}}});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TH1D for 1D histograms to avoid truncation of bin content in case of large number of entries

Suggested change
registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1F, {{2, -0.5, 1.5}}});
registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1D, {{2, -0.5, 1.5}}});

registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1F, {{2, -0.5, 1.5}}});
registry.get<TH1>(HIST("hVertexerType"))->GetXaxis()->SetBinLabel(1 + aod::hf_cand::VertexerType::DCAFitter, "DCAFitter");
registry.get<TH1>(HIST("hVertexerType"))->GetXaxis()->SetBinLabel(1 + aod::hf_cand::VertexerType::KfParticle, "KFParticle");
registry.add("hCandCounter", "hCandCounter", {HistType::kTH1F, {{4, -0.5, 3.5}}});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
registry.add("hCandCounter", "hCandCounter", {HistType::kTH1F, {{4, -0.5, 3.5}}});
registry.add("hCandCounter", "hCandCounter", {HistType::kTH1D, {{4, -0.5, 3.5}}});

@pstahlhu
Copy link
Contributor Author

pstahlhu commented Jul 10, 2025

Hi @fgrosa, thank you for your comments!
I changed the candidate counter histograms to TH1D in both the creator and selector, but I don't think that it's necessary for the hVertexerType, since this is only filled once in the init function. I don't think that this histogram is too important anyway, but it's a nice counter of how many output files were merged in the case of merged output.

I also split the $\eta$ cut in order to be able to apply different cuts on the $\pi$ coming from $\Xi_{c}^{+}$ and the daughters of the $\Xi$.

I run am running a local test at the moment and then will update the PR accordingly.

@fgrosa fgrosa enabled auto-merge (squash) July 10, 2025 13:54
@fgrosa fgrosa merged commit 46680c3 into AliceO2Group:master Jul 10, 2025
13 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants