Skip to content

[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions for PbPb collision process #11946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 2 commits into from
Jul 7, 2025
Merged

[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions for PbPb collision process #11946

fgrosa merged 2 commits into from
Jul 7, 2025

Conversation

@Mingze129
Copy link
Contributor

@Mingze129 Mingze129 commented Jul 7, 2025 •
edited
Loading

Incorrect use of iterator, lead to error when slice on candidates.

@github-actions github-actions bot added the pwghf PWG-HF label Jul 7, 2025
@github-actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 5 disabled

@github-actions github-actions bot changed the title Fix the slice bug [PWGHF] Fix the slice bug Jul 7, 2025
@Mingze129 Mingze129 marked this pull request as ready for review July 7, 2025 11:27
vkucera
vkucera requested changes Jul 7, 2025
View reviewed changes
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment on lines 1477 to 1478
template <typename CollsWithQVecs>
std::vector<float> getQVec(CollsWithQVecs const& collision)
Copy link
Collaborator

@vkucera vkucera Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use an existing type as a template argument.

Copy link
Contributor Author

@Mingze129 Mingze129 Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use 'Coll' instead of 'CollsWithQVecs'.

@vkucera
Copy link
Collaborator

vkucera commented Jul 7, 2025

Incorrect use of iterator, lead to error when slice on candidates.

Why does the grouping not work directly with the iterator?

@vkucera
Copy link
Collaborator

vkucera commented Jul 7, 2025

Please make the PR title more informative by adding the scope of the changes.

@Mingze129
Copy link
Contributor Author

Mingze129 commented Jul 7, 2025

Incorrect use of iterator, lead to error when slice on candidates.

Why does the grouping not work directly with the iterator?

The grouping is working well with the iterator.
The issues is I slice the candidate again while the candidate already sliced (line 2351, 2321).

And we don't want to slice the tracks by the collision, so we have to abandon the iterator.

@Mingze129 Mingze129 changed the title [PWGHF] Fix the slice bug [PWGHF] Stop using the iterator at collisions for PbPb collision process Jul 7, 2025
@vkucera vkucera changed the title [PWGHF] Stop using the iterator at collisions for PbPb collision process [PWGHF] taskCharmPolarisation: Stop using the iterator at collisions for PbPb collision process Jul 7, 2025
@fgrosa fgrosa enabled auto-merge (squash) July 7, 2025 13:41
@fgrosa fgrosa merged commit 9a1890a into AliceO2Group:master Jul 7, 2025
18 of 19 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@Mingze129 @jpxrk
[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions …
4a15401 
…for PbPb collision process (AliceO2Group#11946)
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@Mingze129
[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions …
a6a5f75 
…for PbPb collision process (AliceO2Group#11946)
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@Mingze129
[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions …
27a6ec1 
…for PbPb collision process (AliceO2Group#11946)
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@Mingze129 @vojmach
[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions …
50b4ed3 
…for PbPb collision process (AliceO2Group#11946)
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Mingze129 @jloemker
[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions …
7fdc600 
…for PbPb collision process (AliceO2Group#11946)
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@Mingze129
[PWGHF] taskCharmPolarisation: Stop using the iterator at collisions …
b847db2 
…for PbPb collision process (AliceO2Group#11946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mingze129 @vkucera @fgrosa