Skip to content

Conversation

@sashingo
Copy link
Contributor

@sashingo sashingo commented Jul 7, 2025

  • implemented Z-h correlation
  • fixed a parameter name (suggestion in the last commit)

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

@github-actions github-actions bot changed the title implememted Z-h correlation [PWGHF] implememted Z-h correlation Jul 7, 2025
@vkucera vkucera marked this pull request as draft July 7, 2025 12:15
@sashingo
Copy link
Contributor Author

sashingo commented Jul 9, 2025

Hello, does anyone can approve ?

@vkucera
Copy link
Collaborator

vkucera commented Jul 9, 2025

Hello, does anyone can approve ?

Please address the remaining comment first.

@sashingo
Copy link
Contributor Author

sashingo commented Jul 9, 2025

Which comment ?
I think I took care of them.

@vkucera
Copy link
Collaborator

vkucera commented Jul 9, 2025

Which comment ? I think I took care of them.

The one that has not been resolved.

@sashingo
Copy link
Contributor Author

sashingo commented Jul 9, 2025

Ok, this one.
I overlooked, thanks for pointing.

  if (track.pt() < ptMin)
    continue;

jpxrk
jpxrk previously approved these changes Jul 9, 2025
@vkucera vkucera marked this pull request as ready for review July 10, 2025 05:53
@vkucera vkucera marked this pull request as draft July 10, 2025 05:55
@sashingo sashingo marked this pull request as ready for review July 10, 2025 06:14
@vkucera vkucera changed the title [PWGHF] implememted Z-h correlation [PWGHF] Implement Z-h correlation Jul 10, 2025
@vkucera vkucera enabled auto-merge (squash) July 10, 2025 07:15
@sashingo
Copy link
Contributor Author

Hi Vit and Jonghan, thank you very much for the approval !

@vkucera vkucera merged commit f06546a into AliceO2Group:master Jul 10, 2025
16 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants