Skip to content

[PWGDQ] Temporary test for issues in running in hyperloop #11889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucamicheletti93 merged 2 commits into from
Jul 3, 2025
Merged

[PWGDQ] Temporary test for issues in running in hyperloop #11889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87bbbfc
Part temporary removed to study the issue to run on derived data on h…
lucamicheletti Jul 2, 2025
aaf2293
Fix clang
lucamicheletti Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions PWGDQ/Tasks/tableReader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
//
// Contact: iarsene@cern.ch, i.c.arsene@fys.uio.no
//
#include <iostream>

Check failure on line 14 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[include-iostream] 

Do not include iostream. Use O2 logging instead.
#include <vector>
#include <algorithm>
#include <map>
Expand Down Expand Up @@ -218,11 +218,12 @@
void runEventSelection(TEvent const& event)
{
if (event.runNumber() != fLastRun) {
auto alppar = fCCDB->getForTimeStamp<o2::itsmft::DPLAlpideParam<0>>("ITS/Config/AlpideParam", event.timestamp());
EventSelectionParams* par = fCCDB->getForTimeStamp<EventSelectionParams>("EventSelection/EventSelectionParams", event.timestamp());
int itsROFrameStartBorderMargin = fConfigITSROFrameStartBorderMargin < 0 ? par->fITSROFrameStartBorderMargin : fConfigITSROFrameStartBorderMargin;
int itsROFrameEndBorderMargin = fConfigITSROFrameEndBorderMargin < 0 ? par->fITSROFrameEndBorderMargin : fConfigITSROFrameEndBorderMargin;
VarManager::SetITSROFBorderselection(alppar->roFrameBiasInBC, alppar->roFrameLengthInBC, itsROFrameStartBorderMargin, itsROFrameEndBorderMargin);
// Part temporary removed to study the issue to run on derived data on hyperloop
// auto alppar = fCCDB->getForTimeStamp<o2::itsmft::DPLAlpideParam<0>>("ITS/Config/AlpideParam", event.timestamp());
// EventSelectionParams* par = fCCDB->getForTimeStamp<EventSelectionParams>("EventSelection/EventSelectionParams", event.timestamp());
// int itsROFrameStartBorderMargin = fConfigITSROFrameStartBorderMargin < 0 ? par->fITSROFrameStartBorderMargin : fConfigITSROFrameStartBorderMargin;
// int itsROFrameEndBorderMargin = fConfigITSROFrameEndBorderMargin < 0 ? par->fITSROFrameEndBorderMargin : fConfigITSROFrameEndBorderMargin;
// VarManager::SetITSROFBorderselection(alppar->roFrameBiasInBC, alppar->roFrameLengthInBC, itsROFrameStartBorderMargin, itsROFrameEndBorderMargin);
fLastRun = event.runNumber();
}

Expand Down Expand Up @@ -360,7 +361,7 @@

// set one histogram directory for each defined track cut
TString histDirNames = "TrackBarrel_BeforeCuts;";
for (auto& cut : fTrackCuts) {

Check failure on line 364 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
histDirNames += Form("TrackBarrel_%s;", cut.GetName());
}

Expand Down Expand Up @@ -405,7 +406,7 @@
bool prefilterSelected = false;
int iCut = 0;

for (auto& track : tracks) {

Check failure on line 409 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
filterMap = 0;
prefilterSelected = false;
VarManager::FillTrack<TTrackFillMap>(track);
Expand Down Expand Up @@ -484,7 +485,7 @@

// set one histogram directory for each defined track cut
TString histDirNames = "TrackMuon_BeforeCuts;";
for (auto& cut : fMuonCuts) {

Check failure on line 488 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
histDirNames += Form("TrackMuon_%s;", cut.GetName());
}

Expand All @@ -507,7 +508,7 @@
// First loop to get muon multiplicity for single muon cumulants
if constexpr (static_cast<bool>(TEventFillMap & VarManager::ObjTypes::ReducedEventQvector)) {
int multMuon = 0;
for (auto& muon : muons) {

Check failure on line 511 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
filterMap = 0;
VarManager::FillTrack<TMuonFillMap>(muon);

Expand All @@ -524,7 +525,7 @@
VarManager::fgValues[VarManager::kMultSingleMuons] = multMuon;
}

for (auto& muon : muons) {

Check failure on line 528 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
filterMap = 0;
VarManager::FillTrack<TMuonFillMap>(muon);
if (fConfigQA) { // TODO: make this compile time
Expand Down Expand Up @@ -614,7 +615,7 @@
template <int TPairType, uint32_t TTrackFillMap, typename TTracks1, typename TTracks2>
void runPrefilterPairing(TTracks1 const& tracks1, TTracks2 const& tracks2)
{
for (auto& [track1, track2] : o2::soa::combinations(o2::soa::CombinationsFullIndexPolicy(tracks1, tracks2))) {

Check failure on line 618 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (track1.sign() * track2.sign() > 0) {
continue;
}
Expand Down Expand Up @@ -644,7 +645,7 @@
fCurrentRun = events.begin().runNumber();
}

for (auto& event : events) {

Check failure on line 648 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (event.isEventSelected()) {
auto groupedPrefilterCandidates = filteredTracks.sliceBy(perCollision, event.globalIndex());
auto groupedBarrelCandidates = barrelTracksSelected->sliceByCached(aod::reducedtrack::reducedeventId, event.globalIndex(), cache);
Expand Down Expand Up @@ -2004,7 +2005,7 @@
fDileptonCut = *dqcuts::GetCompositeCut(configDileptonCutNamesStr.Data());
TString configQuadruletCutNamesStr = fConfigQuadrupletCuts.value;
std::unique_ptr<TObjArray> objArray(configQuadruletCutNamesStr.Tokenize(","));
for (Int_t icut = 0; icut < objArray->GetEntries(); ++icut) {

Check failure on line 2008 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
TString cutName = objArray->At(icut)->GetName();
fQuadrupletCutNames.push_back(cutName);
fQuadrupletCuts.push_back(*dqcuts::GetCompositeCut(cutName.Data()));
Expand Down Expand Up @@ -2185,7 +2186,7 @@
// The histogram classes and their components histograms are defined below depending on the name of the histogram class
//
std::unique_ptr<TObjArray> objArray(histClasses.Tokenize(";"));
for (Int_t iclass = 0; iclass < objArray->GetEntries(); ++iclass) {

Check failure on line 2189 in PWGDQ/Tasks/tableReader.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
TString classStr = objArray->At(iclass)->GetName();
histMan->AddHistClass(classStr.Data());

Expand Down
Loading