Skip to content

[Common] Use metadataHelper from namespace #11885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 2 commits into from
Aug 1, 2025
Merged

[Common] Use metadataHelper from namespace #11885

njacazio merged 2 commits into from
Aug 1, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jul 2, 2025

No description provided.

@github-actions github-actions bot added the common label Jul 2, 2025
@github-actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Use metadataHelper from namespace [Common] Use metadataHelper from namespace Jul 2, 2025
@njacazio njacazio marked this pull request as ready for review July 14, 2025 10:31
@njacazio njacazio requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners July 14, 2025 10:31
@njacazio njacazio enabled auto-merge (squash) July 14, 2025 10:31
@alibuild
Copy link
Collaborator

alibuild commented Jul 14, 2025

Error while checking build/O2Physics/o2 for 739e610 at 2025-07-15 00:32:

## sw/BUILD/a99677461b894422bf527eaab7b35ee0f860fcea-latest/log
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestamp.cxx:32:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestamp.cxx:61:13: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestamp.cxx:133:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestampTester.cxx:36:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestampTester.cxx:57:47: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestampTester.cxx:69:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:41:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:279:36: error: 'metadataInfo' was not declared in this scope; did you mean 'metadata'?
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:550:40: error: 'metadataInfo' was not declared in this scope; did you mean 'metadata'?
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:782:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:43:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:158:34: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:422:40: error: 'metadataInfo' was not declared in this scope; did you mean 'metadata'?
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:831:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:49:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:114:48: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:133:48: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:172:43: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:187:43: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:202:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelectionService.cxx:47:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelectionService.cxx:93:47: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelectionService.cxx:156:47: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelectionService.cxx:180:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelection.cxx:50:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelection.cxx:573:9: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/eventSelection.cxx:1460:3: error: 'metadataInfo' was not declared in this scope
ninja: build stopped: subcommand failed.


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestamp.cxx:32:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestamp.cxx:61:13: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestamp.cxx:133:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestampTester.cxx:36:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestampTester.cxx:57:47: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/timestampTester.cxx:69:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:41:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:279:36: error: 'metadataInfo' was not declared in this scope; did you mean 'metadata'?
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:550:40: error: 'metadataInfo' was not declared in this scope; did you mean 'metadata'?
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:782:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:43:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:158:34: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:422:40: error: 'metadataInfo' was not declared in this scope; did you mean 'metadata'?
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:831:3: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:49:1: error: 'MetadataHelper' does not name a type
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:114:48: error: 'metadataInfo' was not declared in this scope
/sw/SOURCES/O2Physics/11885-slc9_x86-64/0/Common/TableProducer/multCentTable.cxx:133:48: error: 'metadataInfo' was not declared in this scope
[0 more errors; see full log]

Full log here.

@njacazio njacazio force-pushed the nj-remove-meadata branch from 739e610 to 0bfa04a Compare July 15, 2025 17:22
@njacazio njacazio merged commit 46990fb into master Aug 1, 2025
10 of 13 checks passed
@njacazio njacazio deleted the nj-remove-meadata branch August 1, 2025 09:35
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
@njacazio @jpxrk
[Common] Use metadataHelper from namespace (AliceO2Group#11885)
50fd596
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@njacazio @jloemker
[Common] Use metadataHelper from namespace (AliceO2Group#11885)
324c8ee
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@njacazio
[Common] Use metadataHelper from namespace (AliceO2Group#11885)
4c90f03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njacazio @alibuild @ddobrigk