Skip to content

Conversation

@mfaggin
Copy link
Collaborator

@mfaggin mfaggin commented Jul 1, 2025

@Mingyu3360715 this PR should solve the issue we observe for the MC matching.

PS: we need to wait the PR #11854 before merging the current one, convert to draft

@github-actions github-actions bot added the pwghf PWG-HF label Jul 1, 2025
@github-actions github-actions bot changed the title [PWGHF]: remove duplicated consuming of McParticles. [PWGHF] remove duplicated consuming of McParticles. Jul 1, 2025
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

alibuild commented Jul 1, 2025

Error while checking build/O2Physics/o2 for d8a1da7 at 2025-07-01 11:59:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11855-slc9_x86-64/0/Common/Core/RecoDecay.h:790:46: error: cannot convert 'o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<3313470560>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >' to 'const o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<1386461136>, o2::aod::Hash<895908964>, o2::aod::Hash<2286545062> > >::iterator&' {aka 'const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<1386461136>, o2::aod::Hash<895908964>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<1386461136>, o2::aod::Hash<895908964>, o2::aod::Hash<2286545062> > >, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<1386461136>, o2::aod::Hash<895908964>, o2::aod::Hash<2286545062> > >&'}
ninja: build stopped: subcommand failed.

Full log here.

@mfaggin mfaggin marked this pull request as draft July 1, 2025 10:39
@vkucera vkucera changed the title [PWGHF] remove duplicated consuming of McParticles. [PWGHF] Σc0++: remove duplicated consuming of McParticles. Jul 1, 2025
@vkucera vkucera changed the title [PWGHF] Σc0++: remove duplicated consuming of McParticles. [PWGHF] Σc0++: Remove duplicated consuming of McParticles. Jul 1, 2025
@vkucera vkucera changed the title [PWGHF] Σc0++: Remove duplicated consuming of McParticles. [PWGHF] Σc0,++: Remove duplicated consuming of McParticles. Jul 1, 2025
@mfaggin mfaggin marked this pull request as ready for review July 2, 2025 06:56
@mfaggin mfaggin enabled auto-merge (squash) July 2, 2025 07:40
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mfaggin.

@mfaggin mfaggin marked this pull request as draft July 2, 2025 14:32
auto-merge was automatically disabled July 2, 2025 14:32

Pull request was converted to draft

@mfaggin mfaggin marked this pull request as ready for review July 2, 2025 14:32
@mfaggin mfaggin enabled auto-merge (squash) July 2, 2025 14:33
alibuild
alibuild previously approved these changes Jul 2, 2025
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mfaggin.

@mfaggin mfaggin disabled auto-merge July 3, 2025 12:34
@mfaggin mfaggin enabled auto-merge (squash) July 3, 2025 12:34
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mfaggin.

@mfaggin mfaggin merged commit 3635c64 into AliceO2Group:master Jul 3, 2025
13 checks passed
@mfaggin mfaggin deleted the cleanScMcMatch branch July 3, 2025 12:35
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants