-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGLF] Modification in event selection cuts #11805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 33 errors, |
| ((phi > ((M_PI / 2. - 0.1) * M_PI) - cfgPhiCut) && | ||
| (phi < ((M_PI / 2. - 0.1) * M_PI) + cfgPhiCut))) | ||
| ((phi > o2::constants::math::PI - cfgPhiCut) && (phi < o2::constants::math::PI + cfgPhiCut)) || | ||
| (phi > 2. * o2::constants::math::PI - cfgPhiCut) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace 2. * o2::constants::math::PI by o2::constants::math::TwoPI
| AxisSpec DeltaZAxis = {61, -6.1, 6.1}; | ||
| AxisSpec ZAxis = {301, -30.1, 30.1}; | ||
| AxisSpec PhiAxis = {629, 0, 2 * M_PI, "Rad", "phi axis"}; | ||
| AxisSpec PhiAxis = {629, 0, 2 * o2::constants::math::PI, "Rad", "phi axis"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace 2. * o2::constants::math::PI by o2::constants::math::TwoPI
Please consider the following formatting changes to AliceO2Group#11805
abmodak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the following changes
for (auto& bc : bcs) => for (const auto& bc : bcs)
for (auto& collision : collisions) => for (const auto& collision : collisions)
for (auto& track : tracks) => for (const auto& track : tracks)
for (auto& retrack : retracks) => for (const auto& retrack : retracks)
for (auto& particle : perCollisionMCSample) => for (const auto& particle : perCollisionMCSample)
for (auto& particle : perCollisionMCSampleCentral) => for (const auto& particle : perCollisionMCSampleCentral)
Please consider the following formatting changes to AliceO2Group#11805
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
No description provided.