Skip to content

Conversation

@tutripat
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

O2 linter results: ❌ 33 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Modification in event selection cuts [PWGLF] Modification in event selection cuts Jun 27, 2025
((phi > ((M_PI / 2. - 0.1) * M_PI) - cfgPhiCut) &&
(phi < ((M_PI / 2. - 0.1) * M_PI) + cfgPhiCut)))
((phi > o2::constants::math::PI - cfgPhiCut) && (phi < o2::constants::math::PI + cfgPhiCut)) ||
(phi > 2. * o2::constants::math::PI - cfgPhiCut) ||
Copy link
Collaborator

@abmodak abmodak Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace 2. * o2::constants::math::PI by o2::constants::math::TwoPI

AxisSpec DeltaZAxis = {61, -6.1, 6.1};
AxisSpec ZAxis = {301, -30.1, 30.1};
AxisSpec PhiAxis = {629, 0, 2 * M_PI, "Rad", "phi axis"};
AxisSpec PhiAxis = {629, 0, 2 * o2::constants::math::PI, "Rad", "phi axis"};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace 2. * o2::constants::math::PI by o2::constants::math::TwoPI

Please consider the following formatting changes to AliceO2Group#11805
Copy link
Collaborator

@abmodak abmodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the following changes

for (auto& bc : bcs) => for (const auto& bc : bcs)
for (auto& collision : collisions) => for (const auto& collision : collisions)
for (auto& track : tracks) => for (const auto& track : tracks)
for (auto& retrack : retracks) => for (const auto& retrack : retracks)
for (auto& particle : perCollisionMCSample) => for (const auto& particle : perCollisionMCSample)
for (auto& particle : perCollisionMCSampleCentral) => for (const auto& particle : perCollisionMCSampleCentral)

Please consider the following formatting changes to AliceO2Group#11805
@abmodak abmodak enabled auto-merge (squash) June 27, 2025 13:24
@abmodak abmodak merged commit 9fc053f into AliceO2Group:master Jun 27, 2025
12 of 13 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants