[PWGLF] Modification in event selection cuts #11791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tutripat
requested review from
abmodak,
alibuild,
gbencedi and
skundu692
as code owners
|
O2 linter results: ❌ 68 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to #11791
abmodak
reviewed
Jun 26, 2025
| } | ||
| registry.fill(HIST("EventSelection"), 3.); | ||
| if (!useEvSel || (useEvSel && collision.selection_bit(aod::evsel::kIsTriggerTVX) && collision.selection_bit(aod::evsel::kNoTimeFrameBorder))) { | ||
| registry.fill(HIST("EventSelection"), 4.); |
Collaborator
There was a problem hiding this comment.
Please also separate out kNoTimeFrameBorder cut like you did for kNoITSROFrameBorder
abmodak
reviewed
Jun 26, 2025
| { | ||
| return; | ||
| } | ||
| if (!useEvSel || (useEvSel && collision.selection_bit(aod::evsel::kIsTriggerTVX) && collision.selection_bit(aod::evsel::kNoTimeFrameBorder))) { |
Collaborator
There was a problem hiding this comment.
Please also separate out kNoTimeFrameBorder cut like you did for kNoITSROFrameBorder
abmodak
requested changes
Jun 26, 2025
Collaborator
abmodak
left a comment
abmodak
left a comment
There was a problem hiding this comment.
Dear @tutripat,
It would be good if you separate out all 3 conditions of sel8. In future, whenever you need, you can switch them on/off.
There are also many O2 linter errors; at least you can consider some of them.
e.g. M_PI => o2::constants::math::PI
Thanks,
Abhi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.