-
Notifications
You must be signed in to change notification settings - Fork 614
[PWGCF] Request to pull the needed code for hyperloop #11773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 1 errors, |
Please consider the following formatting changes to #11773
victor-gonzalez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving forward this analysis!!
There are a few things that need to be addressed
- the header of the PR is meaningless. Could you please use instead something that reflects the functionality added?
- the source file/task name is ambiguous. Could you please use instead
corrections? Justcorrecan be interpreted as correlations
Additionally, have you considered using the centralized Q vector production? They are produced from several detectors, several harmonics and they are corrected in different steps for different datasets. This is just a suggestion in case you want to consider it
|
And, please, never push code that has not been compiled and tested locally before |
Adding files for q2 calculation in PbPb_pass5.