Skip to content

Conversation

@CyF1rmiana
Copy link
Contributor

Adding files for q2 calculation in PbPb_pass5.

@github-actions
Copy link

github-actions bot commented Jun 26, 2025

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Request to pull the needed code for hyperloop [PWGCF] Request to pull the needed code for hyperloop Jun 26, 2025
@shouqiye shouqiye enabled auto-merge (squash) June 27, 2025 09:22
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving forward this analysis!!
There are a few things that need to be addressed

  • the header of the PR is meaningless. Could you please use instead something that reflects the functionality added?
  • the source file/task name is ambiguous. Could you please use instead corrections? Just corre can be interpreted as correlations

Additionally, have you considered using the centralized Q vector production? They are produced from several detectors, several harmonics and they are corrected in different steps for different datasets. This is just a suggestion in case you want to consider it

@victor-gonzalez victor-gonzalez disabled auto-merge June 27, 2025 09:23
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for f13db67 at 2025-06-27 11:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11773-slc9_x86-64/0/PWGCF/Flow/Tasks/flowEseCorre.cxx:181:41: error: 'i' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez
Copy link
Collaborator

And, please, never push code that has not been compiled and tested locally before
Central resources are scarce and shared. Please, help others

@CyF1rmiana CyF1rmiana closed this by deleting the head repository Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants