Skip to content

[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy #11747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alcaliva merged 4 commits into from
Jun 26, 2025
Merged

[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy #11747

alcaliva merged 4 commits into from
Jun 26, 2025

Conversation

@amaringarcia
Copy link
Contributor

@amaringarcia amaringarcia commented Jun 24, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

O2 linter results: ❌ 140 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title [DPG][Common] Test of dE/dx correction for occupancy [Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy Jun 24, 2025
@alibuild alibuild mentioned this pull request Jun 24, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Jun 24, 2025

Error while checking build/O2Physics/o2 for 674113f at 2025-06-24 15:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/Common/TableProducer/PID/pidTPCBase.h:97:27: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<float>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/Common/TableProducer/PID/pidTPCBase.h:98:27: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<float>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/Common/TableProducer/PID/pidTPCBase.cxx:130:13: error: unused variable 'signedP' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/Common/TableProducer/PID/pidTPCBase.h:97:27: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<float>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/Common/TableProducer/PID/pidTPCBase.h:98:27: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<float>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

alcaliva
alcaliva previously approved these changes Jun 24, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Jun 24, 2025

Error while checking build/O2Physics/o2 for c450b27 at 2025-06-24 16:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:12: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:26: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:38: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:38: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:165: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:176: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:176: error: right operand of comma operator has no effect [-Werror=unused-value]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Jun 24, 2025

Error while checking build/O2Physics/o2 for b61a718 at 2025-06-24 16:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:12: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:26: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:38: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:38: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:165: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:176: error: right operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/11747-slc9_x86-64/0/DPG/Tasks/TPC/tpcSkimsTableCreator.cxx:1285:176: error: right operand of comma operator has no effect [-Werror=unused-value]
ninja: build stopped: subcommand failed.

Full log here.

@alcaliva alcaliva enabled auto-merge (squash) June 24, 2025 19:17
@alcaliva alcaliva merged commit f1d4570 into AliceO2Group:master Jun 26, 2025
13 of 15 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@amaringarcia @jpxrk
[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy (Al…
4d2ae99 
…iceO2Group#11747)
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@amaringarcia
[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy (Al…
071b9d6 
…iceO2Group#11747)
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@amaringarcia
[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy (Al…
7c53ed1 
…iceO2Group#11747)
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@amaringarcia @vojmach
[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy (Al…
32f0971 
…iceO2Group#11747)
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@amaringarcia @jloemker
[Common,DPG] [DPG][Common] Test of dE/dx correction for occupancy (Al…
3ee5401 
…iceO2Group#11747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iarsene iarsene iarsene approved these changes

@alcaliva alcaliva alcaliva approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

@catalinristea catalinristea Awaiting requested review from catalinristea catalinristea is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

Assignees

No one assigned

Labels

common dpg

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amaringarcia @alibuild @iarsene @alcaliva