Skip to content

Conversation

@amatyja
Copy link
Collaborator

@amatyja amatyja commented Jun 21, 2025

Added rct_raw variable to UD tables (RCT based flags for each collision)
New converter V003 for UDCCollisionsSelEvents added + CMakeList
New column added to SGCandProducer + configurables
DGCandProducer and UPCCandidateProducer adopted
Predefined function to select CBT or CBT_hadronPID or the same with ZDC from RCT

@github-actions
Copy link

github-actions bot commented Jun 21, 2025

O2 linter results: ❌ 151 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGUD - Added RCT flags to UD tables [PWGUD] PWGUD - Added RCT flags to UD tables Jun 21, 2025
@amatyja amatyja changed the title [PWGUD] PWGUD - Added RCT flags to UD tables [PWGUD] Added RCT flags to UD tables Jun 21, 2025
@amatyja
Copy link
Collaborator Author

amatyja commented Jun 21, 2025

Dear @rolavick, @vkucera,
I run: clang-format -i CMakeLists.txt
It destroys the file completely. Copyright notice is wrong and workflow names are bad. How to fix it and commit it correctly?
Best regards
Adam

@vkucera
Copy link
Collaborator

vkucera commented Jun 22, 2025

Dear @rolavick, @vkucera, I run: clang-format -i CMakeLists.txt It destroys the file completely. Copyright notice is wrong and workflow names are bad. How to fix it and commit it correctly? Best regards Adam

Hi @amatyja ,

  1. You don't need to run clang-format at all. See the contribution instructions.
  2. If you do run clang format, run the correct command, mentioned in the O2 coding guidelines.
  3. clang-format is used for formatting C++ files, not CMake files.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 4269a61 at 2025-06-23 10:15:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:61 (message):

Full log here.

vkucera
vkucera previously approved these changes Jun 24, 2025
@rolavick rolavick enabled auto-merge (squash) June 24, 2025 13:00
@rolavick rolavick merged commit e2ff8e7 into AliceO2Group:master Jun 24, 2025
14 of 15 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants