Skip to content

[PWGEM/PhotonMeson,PWGJE/EMCal] Include BCWise centrality and qa histograms #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhemmer-cern merged 4 commits into from
Jun 19, 2025
Merged

[PWGEM/PhotonMeson,PWGJE/EMCal] Include BCWise centrality and qa histograms #11694

mhemmer-cern merged 4 commits into from
Jun 19, 2025

Conversation

@nstrangm
Copy link
Contributor

@nstrangm nstrangm commented Jun 19, 2025

EM:

  • Move from collision wise to BC wise centrality in gammagamma task
  • Rename pi0task to gammagamma task to allow for addition of eta (in a later PR)

JE:

  • Add DMC7 as DCal L0 trigger to list of emcal readout triggers (Bugfix)

@github-actions
Copy link

github-actions bot commented Jun 19, 2025 •
edited
Loading

O2 linter results: ❌ 17 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Jun 19, 2025
Merged
nstrangm added a commit to nstrangm/O2Physics that referenced this pull request Jun 19, 2025
@nstrangm
Merge pull request #20 from alibuild/alibot-cleanup-11694
eddaf96 
[PWGEM] Please consider the following formatting changes to AliceO2Group#11694
mhemmer-cern
mhemmer-cern previously approved these changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@mhemmer-cern mhemmer-cern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mhemmer-cern mhemmer-cern enabled auto-merge (squash) June 19, 2025 18:31
@alibuild
Copy link
Collaborator

alibuild commented Jun 19, 2025

Error while checking build/O2Physics/o2 for eddaf96 at 2025-06-19 21:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11694-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/bcWiseClusterSkimmer.cxx:320:16: error: variable 'centrality' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled June 19, 2025 19:15

Head branch was pushed to by a user without write access

@alibuild alibuild mentioned this pull request Jun 19, 2025
Merged
@nstrangm
Merge pull request #21 from alibuild/alibot-cleanup-11694
56d3715 
[PWGEM] Please consider the following formatting changes to AliceO2Group#11694
@mhemmer-cern mhemmer-cern enabled auto-merge (squash) June 19, 2025 19:21
@mhemmer-cern mhemmer-cern merged commit 85fe093 into AliceO2Group:master Jun 19, 2025
12 of 13 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
@nstrangm @alibuild
[PWGEM/PhotonMeson,PWGJE/EMCal] Include BCWise centrality and qa hist…
c2776d2 
…ograms (AliceO2Group#11694)

Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@nstrangm @alibuild @jpxrk
[PWGEM/PhotonMeson,PWGJE/EMCal] Include BCWise centrality and qa hist…
6f96bb1 
…ograms (AliceO2Group#11694)

Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@nstrangm @alibuild @vojmach
[PWGEM/PhotonMeson,PWGJE/EMCal] Include BCWise centrality and qa hist…
c548f49 
…ograms (AliceO2Group#11694)

Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@nstrangm @alibuild @jloemker
[PWGEM/PhotonMeson,PWGJE/EMCal] Include BCWise centrality and qa hist…
8622e01 
…ograms (AliceO2Group#11694)

Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhemmer-cern mhemmer-cern mhemmer-cern approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@m-c-danisch m-c-danisch Awaiting requested review from m-c-danisch m-c-danisch is a code owner

@novitzky novitzky Awaiting requested review from novitzky novitzky is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

pwgem pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nstrangm @alibuild @mhemmer-cern