[PWGLF] Update on Nch-dependet corrections #11662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omvazque
requested review from
abmodak,
alibuild,
gbencedi and
skundu692
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
abmodak
reviewed
Jun 17, 2025
| const AxisSpec axisZpos{48, -12., 12., "Vtx_{z} (cm)"}; | ||
| const AxisSpec axisEvent{18, 0.5, 18.5, ""}; | ||
| const AxisSpec axisEta{30, -1.05, +1.05, "#eta"}; | ||
| const AxisSpec axisEta{40, -1., +1., "#eta"}; |
Collaborator
There was a problem hiding this comment.
Hello @omvazque,
Wouldn't it be good to specify `axisEta' as a configurable axis, as you may want to change it later on as per your need? Anyway, you can consider this in your next commit. I am going to approve it.
Thanks,
Abhi
abmodak
approved these changes
Jun 17, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 18, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 20, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.