Skip to content

[PWGHF] removing check in accept. for recMC #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 4 commits into from
Jun 17, 2025
Merged

[PWGHF] removing check in accept. for recMC #11649

fgrosa merged 4 commits into from
Jun 17, 2025

Conversation

@cterrevo
Copy link
Collaborator

@cterrevo cterrevo commented Jun 17, 2025

No description provided.

@github-actions github-actions bot added the pwghf PWG-HF label Jun 17, 2025
@github-actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

alibuild commented Jun 17, 2025

Error while checking build/O2Physics/o2 for d65a829 at 2025-06-17 16:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11649-slc9_x86-64/0/PWGHF/D2H/Tasks/taskXic.cxx:433:30: error: unused variable 'ptProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11649-slc9_x86-64/0/PWGHF/D2H/Tasks/taskXic.cxx:434:30: error: unused variable 'etaProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11649-slc9_x86-64/0/PWGHF/D2H/Tasks/taskXic.cxx:433:30: error: unused variable 'ptProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11649-slc9_x86-64/0/PWGHF/D2H/Tasks/taskXic.cxx:434:30: error: unused variable 'etaProngs' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

fgrosa
fgrosa requested changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cterrevo I think I spotted a typo, could you please check? The rest looks fine to me, thanks!

fgrosa
fgrosa reviewed Jun 17, 2025
View reviewed changes
cterrevo and others added 2 commits June 17, 2025 17:55
@cterrevo @fgrosa
Update PWGHF/D2H/Tasks/taskXic.cxx
fc395ef 
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@cterrevo @fgrosa
Update PWGHF/D2H/Tasks/taskXic.cxx
ee475e5 
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@fgrosa fgrosa enabled auto-merge (squash) June 17, 2025 15:56
@fgrosa fgrosa merged commit adc45e9 into AliceO2Group:master Jun 17, 2025
13 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
@cterrevo @fgrosa @jinhyunni
[PWGHF] removing check in accept. for recMC (AliceO2Group#11649)
8a3a070 
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
@cterrevo @fgrosa
[PWGHF] removing check in accept. for recMC (AliceO2Group#11649)
5893ef7 
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@cterrevo @fgrosa @jpxrk
[PWGHF] removing check in accept. for recMC (AliceO2Group#11649)
37236a3 
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@cterrevo @fgrosa @jloemker
[PWGHF] removing check in accept. for recMC (AliceO2Group#11649)
34f3527 
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosa fgrosa fgrosa approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cterrevo @alibuild @fgrosa