[PWGEM] SingleTrackQC update to THnSparse Data and MC #11640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feisenhu
requested review from
alibuild,
dsekihat,
ivorobye,
mikesas and
rbailhac
as code owners
|
O2 linter results: ❌ 416 errors, |
Collaborator
Collaborator
Author
|
Dear @dsekihat, no I have not forgotten the discussion we had. |
Collaborator
hscheid
reviewed
Jun 18, 2025
| fRegistry.fill(HIST("Track/") + HIST(lepton_source_types[lepton_source_id]) + HIST("positive/hQoverPt"), track.sign() / track.pt()); | ||
| fRegistry.fill(HIST("Track/") + HIST(lepton_source_types[lepton_source_id]) + HIST("positive/hDCAxyz"), track.dcaXY(), track.dcaZ()); | ||
| fRegistry.fill(HIST("Track/") + HIST(lepton_source_types[lepton_source_id]) + HIST("positive/hDCAxyzSigma"), track.dcaXY() / std::sqrt(track.cYY()), track.dcaZ() / std::sqrt(track.cZZ())); | ||
| fRegistry.fill(HIST("Track/") + HIST(lepton_source_types[lepton_source_id]) + HIST("positive/hDCAxyzSigma"), dcaXY, dcaZ); |
Collaborator
There was a problem hiding this comment.
Why is this needed? The Sparse defined in 583 has the information to create exactly this histogram.
Collaborator
|
Was this tested in terms of memory consumption? We should just avoid that the QC is broken, but in general I think the correlations that we check with this are worth studying. |
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 20, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the THnSparse of SingleTrackQC tasks