Skip to content

[Common] Prevent CCDB crash -> always captured #11639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddobrigk merged 2 commits into from
Jun 17, 2025
Merged

[Common] Prevent CCDB crash -> always captured #11639

ddobrigk merged 2 commits into from
Jun 17, 2025

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Jun 17, 2025

This adds the ccdb->setFatalWhenNull(false); setting to the ccdb in the multCentTable. All exceptions are properly caught in subsequent code and dealt with so no need to crash.

@ddobrigk ddobrigk requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners June 17, 2025 03:36
@ddobrigk ddobrigk enabled auto-merge (squash) June 17, 2025 03:36
@github-actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild
alibuild previously approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@alibuild alibuild mentioned this pull request Jun 17, 2025
Merged
@ddobrigk ddobrigk disabled auto-merge June 17, 2025 03:48
@ddobrigk ddobrigk enabled auto-merge (squash) June 17, 2025 03:48
alibuild
alibuild approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk merged commit c29bb51 into AliceO2Group:master Jun 17, 2025
12 of 13 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
@ddobrigk @alibuild @jinhyunni
[Common] Prevent CCDB crash -> always captured (AliceO2Group#11639)
3be471a 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
@ddobrigk @alibuild
[Common] Prevent CCDB crash -> always captured (AliceO2Group#11639)
ec4419b 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@ddobrigk @alibuild @jpxrk
[Common] Prevent CCDB crash -> always captured (AliceO2Group#11639)
2174065 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@ddobrigk @alibuild @jloemker
[Common] Prevent CCDB crash -> always captured (AliceO2Group#11639)
fa29e00 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddobrigk @alibuild