Skip to content

[PWGLF] added configurable enablePureDCAHistogram for enabling pure DCA histogram based on nsigmaTPCKa cut #11593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fmazzasc merged 25 commits into from
Jun 13, 2025
Merged

[PWGLF] added configurable enablePureDCAHistogram for enabling pure DCA histogram based on nsigmaTPCKa cut #11593

fmazzasc merged 25 commits into from
Jun 13, 2025

Conversation

@BanajitBarman
Copy link
Contributor

@BanajitBarman BanajitBarman commented Jun 12, 2025

No description provided.

BanajitBarman and others added 21 commits June 3, 2024 12:32
@BanajitBarman
Added a configurable option for enabling the DCAxyPhi histogram
d23f687
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
dcdccf0
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
4d6e5ec
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
4834df3
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
ca52b85
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
c6a2d9e
@BanajitBarman
added extra configurable for handling minimum tpcChi2NCl
4da264c
@njacazio
Update spectraTOF.cxx
d46c10c
@njacazio
Update spectraTOF.cxx
a7c12ef
@BanajitBarman
added configurable enablepuredcahist for enabling pure DCA histogram …
6de2e04 
…based on nsigmaTPCKa cut
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
5e361d8
@BanajitBarman
Merge remote-tracking branch 'origin/master'
e08dc99
@alibuild
Please consider the following formatting changes
4dd48b8
@BanajitBarman
Merge pull request #3 from alibuild/alibot-cleanup-11571
71b67d3 
Please consider the following formatting changes to AliceO2Group#11571
@BanajitBarman
added space
ad3ed6c
@alibuild
Please consider the following formatting changes
f3a823b
@BanajitBarman
Merge pull request #4 from alibuild/alibot-cleanup-11571
5a6e862 
Please consider the following formatting changes to AliceO2Group#11571
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
67a07e7
@BanajitBarman
Merge branch 'AliceO2Group:master' into master
a72e60b
@BanajitBarman
rename pdg code to pass O2 linter test
6f7fe59
@BanajitBarman
added configurable enablePureDCAHistogram for enabling pure DCA histo…
0c67fa6 
…gram based on nsigmaTPCKa cut
@github-actions github-actions bot added the pwglf label Jun 12, 2025
@github-actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

O2 linter results: ❌ 149 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title added configurable enablePureDCAHistogram for enabling pure DCA histogram based on nsigmaTPCKa cut [PWGLF] added configurable enablePureDCAHistogram for enabling pure DCA histogram based on nsigmaTPCKa cut Jun 12, 2025
fmazzasc
fmazzasc previously approved these changes Jun 12, 2025
View reviewed changes
vkucera
vkucera reviewed Jun 12, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Jun 12, 2025

Error while checking build/O2Physics/o2 for f22022b at 2025-06-13 00:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2113:24: error: 'isKaonTPC' was not declared in this scope; did you mean 'isPionTPC'?
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2249:26: error: 'isKaonTOF' was not declared in this scope; did you mean 'isPionTOF'?
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1911:18: error: unused variable 'isKaonTPC' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11593-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1914:18: error: unused variable 'isKaonTOF' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft June 12, 2025 23:09
@BanajitBarman BanajitBarman marked this pull request as ready for review June 13, 2025 07:39
@BanajitBarman BanajitBarman force-pushed the master branch 3 times, most recently from 05f4b51 to 0c67fa6 Compare June 13, 2025 07:51
@alibuild alibuild mentioned this pull request Jun 13, 2025
Merged
@BanajitBarman
Merge pull request #6 from alibuild/alibot-cleanup-11593
1998c21 
Please consider the following formatting changes to AliceO2Group#11593
@fmazzasc fmazzasc self-requested a review June 13, 2025 12:54
@fmazzasc fmazzasc enabled auto-merge (squash) June 13, 2025 12:55
@fmazzasc fmazzasc merged commit 713bb40 into AliceO2Group:master Jun 13, 2025
12 of 13 checks passed
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@BanajitBarman @njacazio @alibuild
[PWGLF] added configurable enablePureDCAHistogram for enabling pure D…
a56783c 
…CA histogram based on nsigmaTPCKa cut (AliceO2Group#11593)

Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
@BanajitBarman @njacazio
@alibuild @jinhyunni
[PWGLF] added configurable enablePureDCAHistogram for enabling pure D…
fed5d16 
…CA histogram based on nsigmaTPCKa cut (AliceO2Group#11593)

Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
@BanajitBarman @njacazio @alibuild
[PWGLF] added configurable enablePureDCAHistogram for enabling pure D…
eb845cd 
…CA histogram based on nsigmaTPCKa cut (AliceO2Group#11593)

Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@BanajitBarman @njacazio
@alibuild @jpxrk
[PWGLF] added configurable enablePureDCAHistogram for enabling pure D…
8cf01f1 
…CA histogram based on nsigmaTPCKa cut (AliceO2Group#11593)

Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@BanajitBarman @njacazio
@alibuild @CesarOmarRA
[PWGLF] added configurable enablePureDCAHistogram for enabling pure D…
db8e9be 
…CA histogram based on nsigmaTPCKa cut (AliceO2Group#11593)

Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@BanajitBarman @njacazio
@alibuild @jloemker
[PWGLF] added configurable enablePureDCAHistogram for enabling pure D…
53cf9d6 
…CA histogram based on nsigmaTPCKa cut (AliceO2Group#11593)

Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@fmazzasc fmazzasc fmazzasc approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@chiarapinto chiarapinto Awaiting requested review from chiarapinto

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BanajitBarman @alibuild @vkucera @fmazzasc @njacazio