[PWGCF] Addition New PID function #11582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
Preet-Bhanjan
added a commit
to Preet-Bhanjan/O2Physics
that referenced
this pull request
Jun 12, 2025
[PWGCF] Please consider the following formatting changes to AliceO2Group#11582
[PWGCF] Please consider the following formatting changes to AliceO2Group#11582
Preet-Bhanjan
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
Comment on lines
+273
to
+282
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(1, "Filtered track"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(2, "Global tracks"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(3, "PV contributor"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(4, "ITS clusters"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(5, "TPC signal"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(6, "TPC clusters"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(7, "TPC crossed rows"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(8, "Pions"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(9, "Kaons"); | ||
| histos.get<TH1>(HIST("hTrackCount"))->GetXaxis()->SetBinLabel(10, "Protons"); |
Collaborator
There was a problem hiding this comment.
I would suggest using named constants and starting the axis range in -0.5
It will be much more readable and easier to evolve here and when the histogram is filled
Of course, the same for the event count histogram
victor-gonzalez
approved these changes
Jun 12, 2025
lietava
pushed a commit
to lietava/O2Physics
that referenced
this pull request
Jun 14, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 20, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.