Skip to content

[ALICE3] Update FastTracker #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 6 commits into from
Jun 12, 2025
Merged

[ALICE3] Update FastTracker #11570

njacazio merged 6 commits into from
Jun 12, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jun 11, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

O2 linter results: ❌ 79 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update FastTracker [ALICE3] Update FastTracker Jun 11, 2025
@alibuild alibuild mentioned this pull request Jun 11, 2025
Merged
@njacazio njacazio marked this pull request as ready for review June 11, 2025 20:11
@njacazio njacazio enabled auto-merge (squash) June 11, 2025 20:11
alibuild
alibuild previously approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
Merge pull request #45 from alibuild/alibot-cleanup-11570
296a183 
Please consider the following formatting changes to AliceO2Group#11570
@alibuild alibuild mentioned this pull request Jun 11, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Jun 11, 2025

Error while checking build/O2Physics/o2 for 296a183 at 2025-06-11 23:19:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11570-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:430:41: error: narrowing conversion of '((TMath::Cos(((Double_t)alpha)) * ((Double_t)spacePoint.std::array<float, 3>::operator[](0))) + (TMath::Sin(((Double_t)alpha)) * ((Double_t)spacePoint.std::array<float, 3>::operator[](1))))' from 'Double_t' {aka 'double'} to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/11570-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:431:42: error: narrowing conversion of '(((- TMath::Sin(((Double_t)alpha))) * ((Double_t)spacePoint.std::array<float, 3>::operator[](0))) + (TMath::Cos(((Double_t)alpha)) * ((Double_t)spacePoint.std::array<float, 3>::operator[](1))))' from 'Double_t' {aka 'double'} to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/11570-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:287:112: error: unused parameter 'nch' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

njacazio and others added 2 commits June 12, 2025 10:05
@njacazio
Merge pull request #46 from alibuild/alibot-cleanup-11570
9f7b929 
Please consider the following formatting changes to AliceO2Group#11570
@njacazio
UUU
59dab73
@njacazio njacazio disabled auto-merge June 12, 2025 08:33
@njacazio njacazio enabled auto-merge (squash) June 12, 2025 08:33
alibuild
alibuild approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 5e3822f into AliceO2Group:master Jun 12, 2025
12 of 13 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@njacazio @alibuild
[ALICE3] Update FastTracker (AliceO2Group#11570)
8ad368a 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lietava pushed a commit to lietava/O2Physics that referenced this pull request Jun 14, 2025
@njacazio @alibuild @lietava
[ALICE3] Update FastTracker (AliceO2Group#11570)
00a3b2b 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@njacazio @alibuild
[ALICE3] Update FastTracker (AliceO2Group#11570)
db423c0 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
@njacazio @alibuild @jinhyunni
[ALICE3] Update FastTracker (AliceO2Group#11570)
8aad310 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@njacazio @alibuild @CesarOmarRA
[ALICE3] Update FastTracker (AliceO2Group#11570)
4d0e62c 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@njacazio @alibuild @jloemker
[ALICE3] Update FastTracker (AliceO2Group#11570)
1877d63 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njacazio @alibuild