Skip to content

Conversation

@njacazio
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

O2 linter results: ❌ 79 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update FastTracker [ALICE3] Update FastTracker Jun 11, 2025
@njacazio njacazio marked this pull request as ready for review June 11, 2025 20:11
@njacazio njacazio enabled auto-merge (squash) June 11, 2025 20:11
alibuild
alibuild previously approved these changes Jun 11, 2025
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

Please consider the following formatting changes to AliceO2Group#11570
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 296a183 at 2025-06-11 23:19:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11570-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:430:41: error: narrowing conversion of '((TMath::Cos(((Double_t)alpha)) * ((Double_t)spacePoint.std::array<float, 3>::operator[](0))) + (TMath::Sin(((Double_t)alpha)) * ((Double_t)spacePoint.std::array<float, 3>::operator[](1))))' from 'Double_t' {aka 'double'} to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/11570-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:431:42: error: narrowing conversion of '(((- TMath::Sin(((Double_t)alpha))) * ((Double_t)spacePoint.std::array<float, 3>::operator[](0))) + (TMath::Cos(((Double_t)alpha)) * ((Double_t)spacePoint.std::array<float, 3>::operator[](1))))' from 'Double_t' {aka 'double'} to 'float' [-Werror=narrowing]
/sw/SOURCES/O2Physics/11570-slc9_x86-64/0/ALICE3/Core/FastTracker.cxx:287:112: error: unused parameter 'nch' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

njacazio and others added 2 commits June 12, 2025 10:05
Please consider the following formatting changes to AliceO2Group#11570
@njacazio njacazio disabled auto-merge June 12, 2025 08:33
@njacazio njacazio enabled auto-merge (squash) June 12, 2025 08:33
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 5e3822f into AliceO2Group:master Jun 12, 2025
12 of 13 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lietava pushed a commit to lietava/O2Physics that referenced this pull request Jun 14, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants