Skip to content

[PWGLF] do not include ITS internal code #11540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainschotter merged 1 commit into from
Jun 11, 2025
Merged

[PWGLF] do not include ITS internal code #11540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions PWGLF/TableProducer/Strangeness/Converters/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,22 @@ o2physics_add_dpl_workflow(straevselsconverter

o2physics_add_dpl_workflow(straevselsconverter2
SOURCES straevselsconverter2.cxx
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2::ITStracking
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2::ReconstructionDataFormats
COMPONENT_NAME Analysis)

o2physics_add_dpl_workflow(straevselsconverter3
SOURCES straevselsconverter3.cxx
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2::ITStracking
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2::ReconstructionDataFormats
COMPONENT_NAME Analysis)

o2physics_add_dpl_workflow(straevselsconverter4
SOURCES straevselsconverter4.cxx
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2::ITStracking
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore
COMPONENT_NAME Analysis)

o2physics_add_dpl_workflow(straevselsconverter5
SOURCES straevselsconverter5.cxx
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2::ITStracking O2Physics::AnalysisCCDB
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore O2Physics::AnalysisCCDB
COMPONENT_NAME Analysis)

o2physics_add_dpl_workflow(straevselsconverter2rawcents
Expand Down Expand Up @@ -117,4 +117,4 @@ o2physics_add_dpl_workflow(stramccollisionconverter2
o2physics_add_dpl_workflow(zdcneutronsconverter
SOURCES zdcneutronsconverter.cxx
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore
COMPONENT_NAME Analysis)
COMPONENT_NAME Analysis)
11 changes: 6 additions & 5 deletions PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -8,22 +8,23 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "ITStracking/Vertexer.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

Check failure on line 11 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \author is missing, incorrect or misplaced.

Check failure on line 11 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

Check failure on line 11 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.

#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Vertex.h"

using namespace o2;
using namespace o2::framework;

// Converts Stra Event selections from 000 to 001
struct straevselsconverter2 {

Check failure on line 22 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/struct] 

Use UpperCamelCase for names of structs.
Produces<aod::StraEvSels_002> straEvSels_002;

Check failure on line 23 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable] 

Use lowerCamelCase for names of functions and variables.

void process(aod::StraEvSels_001 const& straEvSels_001)
{
for (auto& values : straEvSels_001) {

Check failure on line 27 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter2.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
straEvSels_002(values.sel8(),
values.selection_raw(),
values.multFT0A(),
Expand Down Expand Up @@ -52,7 +53,7 @@
values.totalFDDAmplitudeC(),
values.energyCommonZNA(),
values.energyCommonZNC(),
o2::its::Vertex::FlagsMask /*dummy flag value*/);
o2::dataformats::Vertex<bool>::FlagsMask /*dummy flag value*/);
}
}
};
Expand Down
11 changes: 6 additions & 5 deletions PWGLF/TableProducer/Strangeness/Converters/straevselsconverter3.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "ITStracking/Vertexer.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

Check failure on line 11 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter3.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.

#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Vertex.h"

using namespace o2;
using namespace o2::framework;

Expand All @@ -23,7 +24,7 @@

void process(aod::StraEvSels_002 const& straEvSels_002)
{
for (auto& values : straEvSels_002) {

Check failure on line 27 in PWGLF/TableProducer/Strangeness/Converters/straevselsconverter3.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
straEvSels_003(values.sel8(),
values.selection_raw(),
values.multFT0A(),
Expand Down Expand Up @@ -53,7 +54,7 @@
values.totalFDDAmplitudeC(),
values.energyCommonZNA(),
values.energyCommonZNC(),
o2::its::Vertex::FlagsMask /*dummy flag value*/);
o2::dataformats::Vertex<bool>::FlagsMask /*dummy flag value*/);
}
}
};
Expand Down
8 changes: 4 additions & 4 deletions PWGLF/TableProducer/Strangeness/Converters/straevselsconverter4.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "ITStracking/Vertexer.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"

using namespace o2;
using namespace o2::framework;

Expand Down
10 changes: 5 additions & 5 deletions PWGLF/TableProducer/Strangeness/Converters/straevselsconverter5.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

#include "CCDB/BasicCCDBManager.h"
#include "DataFormatsParameters/AggregatedRunInfo.h"
#include "ITStracking/Vertexer.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"

using namespace o2;
using namespace o2::framework;
Expand Down
Loading