Skip to content

Conversation

@SuJeong-Ji
Copy link
Contributor

Upload 'k1analysismicro.cxx' which is a short version of 'k1analysis.cxx ' for QA.
For the rest of the files, typo is fixed 'resodmciroaughter' -> 'resomicrodaughter'

@github-actions
Copy link

github-actions bot commented Jun 10, 2025

O2 linter results: ❌ 108 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Upload k1analysismicro.cxx and fix typo [PWGLF] Upload k1analysismicro.cxx and fix typo Jun 10, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for afdcc3b at 2025-06-10 10:02:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:110:20: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:112:20: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:135:40: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:136:61: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:176:62: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:177:61: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:178:70: error: 'o2::aod::resodmciroaughter' has not been declared
/sw/SOURCES/O2Physics/11528-slc9_x86-64/0/Tutorials/PWGLF/Resonance/resonancesMicrotrack.cxx:180:72: error: 'o2::aod::resodmciroaughter' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@BongHwi
Copy link
Collaborator

BongHwi commented Jun 12, 2025

Hello @SuJeong-Ji ,
Thanks for the update! I missed that the class name was wrong...

I think you missed the CMakeList file to build your task. This is essential for your task and proper test.
And I found several trivial o2linter suggestions, such as std library and const for the for loop opmization.
Please update them and let us know!

Cheers,
Bong-Hwi

Please consider the following formatting changes to AliceO2Group#11528
@SuJeong-Ji
Copy link
Contributor Author

Hi @BongHwi,

Thank you very much for your comments.
I have updated to a new version of the analysis code and 'CMakeLists.txt'.

Best regards,
Su

@BongHwi BongHwi changed the title [PWGLF] Upload k1analysismicro.cxx and fix typo [PWGLF,Tutorial] Upload k1analysismicro.cxx and fix typo Jun 14, 2025
@BongHwi
Copy link
Collaborator

BongHwi commented Jun 14, 2025

Hello @SuJeong-Ji , looks fine to me.
Thanks for the update.

BongHwi
BongHwi previously approved these changes Jun 14, 2025
@BongHwi BongHwi enabled auto-merge (squash) June 14, 2025 03:44
auto-merge was automatically disabled June 15, 2025 08:10

Head branch was pushed to by a user without write access

@BongHwi BongHwi merged commit 85d0325 into AliceO2Group:master Jun 20, 2025
14 of 15 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
@SuJeong-Ji SuJeong-Ji deleted the k1analysis-update branch June 30, 2025 01:06
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants