Skip to content

[PWGLF] Improve variable selection in mixed event #11522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skundu692 merged 3 commits into from
Jun 9, 2025
Merged

[PWGLF] Improve variable selection in mixed event #11522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd1cdbb
add new expression for angular correlation
skundu692 Jun 8, 2025
f8b3ba9
Improve variable selection in mixed event
skundu692 Jun 9, 2025
aaa943e
Fix clang formating
skundu692 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 87 additions & 48 deletions PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@
Configurable<bool> cfgEvtRCTFlagCheckerLimitAcceptAsBad{"cfgEvtRCTFlagCheckerLimitAcceptAsBad", true, "Evt sel: RCT flag checker treat Limited Acceptance As Bad"};
} rctCut;
// mixing
Configurable<int> cosCalculation{"cosCalculation", 1, "cos calculation"};
Configurable<int> mixingCombination{"mixingCombination", 1, "mixing Combination"};
Configurable<int> cosCalculation{"cosCalculation", 0, "cos calculation"};
Configurable<int> mixingCombination{"mixingCombination", 0, "mixing Combination"};
Configurable<bool> mixingEvSel{"mixingEvSel", false, "mixingEvSel"};
Configurable<int> cfgCutOccupancy{"cfgCutOccupancy", 2000, "Occupancy cut"};
ConfigurableAxis axisVertex{"axisVertex", {5, -10, 10}, "vertex axis for bin"};
Expand Down Expand Up @@ -128,7 +128,8 @@
AxisSpec thnAxisInvMasspair{iMNbinspair, lbinIMpair, hbinIMpair, "#it{M} (GeV/#it{c}^{2})"};
histos.add("hEvtSelInfo", "hEvtSelInfo", kTH1F, {{10, 0, 10.0}});
histos.add("hPtDiff", "hPtDiff", kTH1F, {{1000, 0, 100.0}});
histos.add("hRDiff", "hRDiff", kTH1F, {{640, 0, 16.0}});
histos.add("hPhiDiff", "hPhiDiff", kTH1F, {{800, -8.0, 8.0}});
histos.add("hRDiff", "hRDiff", kTH1F, {{640, -16.0, 16.0}});
histos.add("hv0Mult", "hv0Mult", kTH1F, {{10001, -0.5, 10000.5}});
histos.add("hCentrality", "Centrality distribution", kTH1F, {{configcentAxis}});
histos.add("hSparseLambdaLambda", "hSparseLambdaLambda", HistType::kTHnSparseF, {thnAxisInvMass, thnAxisInvMass, configthnAxisPol, configcentAxis, thnAxisInvMasspair}, true);
Expand Down Expand Up @@ -244,8 +245,8 @@
const ROOT::Math::PxPyPzMVector& Lambdadummy,
const ROOT::Math::PxPyPzMVector& AntiLambdadummy)
{
const double minMass = 1.0;
const double maxMass = 2.0;
const double minMass = 1.09;
const double maxMass = 1.14;
return (lambdaTag && aLambdaTag &&
(Lambdadummy.M() > minMass && Lambdadummy.M() < maxMass) &&
(AntiLambdadummy.M() > minMass && AntiLambdadummy.M() < maxMass));
Expand Down Expand Up @@ -293,8 +294,8 @@
double cosTheta2 = proton2LambdaRF.Vect().Unit().Dot(quantizationAxis);
cosThetaDiff = cosTheta1 * cosTheta2;
}

double deltaR = TMath::Sqrt(TMath::Power(particle1.Eta() - particle2.Eta(), 2.0) + TMath::Power(particle1.Phi() - particle2.Phi(), 2.0));
double deltaPhi = RecoDecay::constrainAngle(particle1.Phi() - particle2.Phi(), 0.0);
double deltaR = TMath::Sqrt(TMath::Power(particle1.Eta() - particle2.Eta(), 2.0) + TMath::Power(deltaPhi, 2.0));

Check failure on line 298 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
if (datatype == 0) {
if (tag1 && tag3) {
histos.fill(HIST("hSparseLambdaLambda"), particle1.M(), particle2.M(), cosThetaDiff, centrality, deltaR);
Expand Down Expand Up @@ -325,7 +326,7 @@
}
}

if (datatype == 2) {

Check failure on line 329 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (tag1 && tag3) {
histos.fill(HIST("hSparseLambdaLambdaMixed"), particle1.M(), particle2.M(), cosThetaDiff, centrality, deltaR);
}
Expand Down Expand Up @@ -411,7 +412,7 @@

return {lambdaTag, aLambdaTag, true}; // Valid candidate
}

ROOT::Math::PxPyPzMVector lambda0, antiLambda0, proton0, pion0, antiProton0, antiPion0;
ROOT::Math::PxPyPzMVector lambda, antiLambda, proton, pion, antiProton, antiPion;
ROOT::Math::PxPyPzMVector lambda2, antiLambda2, proton2, pion2, antiProton2, antiPion2;
ROOT::Math::PxPyPzMVector lambdamc, antiLambdamc, protonmc, pionmc, antiProtonmc, antiPionmc;
Expand Down Expand Up @@ -478,7 +479,12 @@
pion = ROOT::Math::PxPyPzMVector(v0.pxpos(), v0.pypos(), v0.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda = antiProton + pion;
}

if (lambdaTag && (lambda.M() < lbinIM || lambda.M() > hbinIM)) {
continue;
}
if (aLambdaTag && (antiLambda.M() < lbinIM || antiLambda.M() > hbinIM)) {
continue;
}
auto postrack1 = v0.template posTrack_as<AllTrackCandidates>();
auto negtrack1 = v0.template negTrack_as<AllTrackCandidates>();

Expand All @@ -504,6 +510,12 @@
pion2 = ROOT::Math::PxPyPzMVector(v02.pxpos(), v02.pypos(), v02.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda2 = antiProton2 + pion2;
}
if (lambdaTag2 && (lambda2.M() < lbinIM || lambda2.M() > hbinIM)) {
continue;
}
if (aLambdaTag2 && (antiLambda2.M() < lbinIM || antiLambda2.M() > hbinIM)) {
continue;
}
auto postrack2 = v02.template posTrack_as<AllTrackCandidates>();
auto negtrack2 = v02.template negTrack_as<AllTrackCandidates>();
if (postrack1.globalIndex() == postrack2.globalIndex() || negtrack1.globalIndex() == negtrack2.globalIndex()) {
Expand Down Expand Up @@ -533,7 +545,7 @@
Preslice<aod::V0Datas> tracksPerCollisionV0 = aod::v0data::collisionId;
void processME(EventCandidates const& collisions, AllTrackCandidates const&, ResoV0s const& V0s)
{
for (auto& [collision1, collision2] : selfCombinations(colBinning, nMix, -1, collisions, collisions)) {

Check failure on line 548 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
// LOGF(info, "Mixed event collisions: (%d, %d)", collision1.index(), collision2.index());
if (rctCut.requireRCTFlagChecker && !rctChecker(collision1)) {
continue;
Expand Down Expand Up @@ -600,7 +612,7 @@
size_t cols = groupV01.size() + 20;
std::vector<std::vector<bool>> pairStatus(rows, std::vector<bool>(cols, false));
histos.fill(HIST("hv0Mult"), groupV01.size());
for (auto& [t1, t2] : soa::combinations(o2::soa::CombinationsFullIndexPolicy(groupV01, groupV02))) {

Check failure on line 615 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
bool pairfound = false;
if (t2.index() <= t1.index()) {
continue;
Expand Down Expand Up @@ -630,8 +642,42 @@
if (postrack1.globalIndex() == postrack2.globalIndex() || negtrack1.globalIndex() == negtrack2.globalIndex()) {
continue;
}
auto samePairSumPt = t1.pt() + t2.pt();
auto samePairR = TMath::Sqrt(TMath::Power(t1.phi() - t2.phi(), 2.0) + TMath::Power(t1.eta() - t2.eta(), 2.0));
// auto samePairSumPt = t1.pt() + t2.pt();
double deltaPhiSame = RecoDecay::constrainAngle(t1.phi() - t2.phi(), 0.0);
auto samePairR = TMath::Sqrt(TMath::Power(deltaPhiSame, 2.0) + TMath::Power(t1.eta() - t2.eta(), 2.0));

Check failure on line 647 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.

if (lambdaTag1) {
proton0 = ROOT::Math::PxPyPzMVector(t1.pxpos(), t1.pypos(), t1.pzpos(), o2::constants::physics::MassProton);
antiPion0 = ROOT::Math::PxPyPzMVector(t1.pxneg(), t1.pyneg(), t1.pzneg(), o2::constants::physics::MassPionCharged);
lambda0 = proton0 + antiPion0;
}
if (aLambdaTag1) {
antiProton0 = ROOT::Math::PxPyPzMVector(t1.pxneg(), t1.pyneg(), t1.pzneg(), o2::constants::physics::MassProton);
pion0 = ROOT::Math::PxPyPzMVector(t1.pxpos(), t1.pypos(), t1.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda0 = antiProton0 + pion0;
}
if (lambdaTag1 && (lambda0.M() < lbinIM || lambda0.M() > hbinIM)) {
continue;
}
if (aLambdaTag1 && (antiLambda0.M() < lbinIM || antiLambda0.M() > hbinIM)) {
continue;
}
if (lambdaTag2) {
proton = ROOT::Math::PxPyPzMVector(t2.pxpos(), t2.pypos(), t2.pzpos(), o2::constants::physics::MassProton);
antiPion = ROOT::Math::PxPyPzMVector(t2.pxneg(), t2.pyneg(), t2.pzneg(), o2::constants::physics::MassPionCharged);
lambda = proton + antiPion;
}
if (aLambdaTag2) {
antiProton = ROOT::Math::PxPyPzMVector(t2.pxneg(), t2.pyneg(), t2.pzneg(), o2::constants::physics::MassProton);
pion = ROOT::Math::PxPyPzMVector(t2.pxpos(), t2.pypos(), t2.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda = antiProton + pion;
}
if (lambdaTag2 && (lambda.M() < lbinIM || lambda.M() > hbinIM)) {
continue;
}
if (aLambdaTag2 && (antiLambda.M() < lbinIM || antiLambda.M() > hbinIM)) {
continue;
}
for (const auto& t3 : groupV03) {
// if (pairStatus[t3.index()][t2.index()]) {
// LOGF(info, "repeat match found v0 id: (%d, %d)", t3.index(), t2.index());
Expand All @@ -653,55 +699,49 @@
if (lambdaTag1 != lambdaTag3 || aLambdaTag1 != aLambdaTag3) {
continue;
}
// if (std::abs(t1.pt() - t3.pt()) > ptMix) {
// continue;
// }
// if (std::abs(t1.eta() - t3.eta()) > etaMix) {
// continue;
// }
// if (std::abs(t1.phi() - t3.phi()) > phiMix) {
// continue;
// }
auto mixPairSumPt = t3.pt() + t2.pt();
auto mixPairR = TMath::Sqrt(TMath::Power(t3.phi() - t2.phi(), 2.0) + TMath::Power(t3.eta() - t2.eta(), 2.0));
histos.fill(HIST("hPtDiff"), TMath::Abs(mixPairSumPt - samePairSumPt));
histos.fill(HIST("hRDiff"), TMath::Abs(mixPairR - samePairR));
if (mixingCombination == 0 && std::abs(t1.pt() - t3.pt()) > ptMix) {
continue;

if (lambdaTag3) {
proton2 = ROOT::Math::PxPyPzMVector(t3.pxpos(), t3.pypos(), t3.pzpos(), o2::constants::physics::MassProton);
antiPion2 = ROOT::Math::PxPyPzMVector(t3.pxneg(), t3.pyneg(), t3.pzneg(), o2::constants::physics::MassPionCharged);
lambda2 = proton2 + antiPion2;
}
if (aLambdaTag3) {
antiProton2 = ROOT::Math::PxPyPzMVector(t3.pxneg(), t3.pyneg(), t3.pzneg(), o2::constants::physics::MassProton);
pion2 = ROOT::Math::PxPyPzMVector(t3.pxpos(), t3.pypos(), t3.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda2 = antiProton2 + pion2;
}
if (mixingCombination == 0 && std::abs(t1.eta() - t3.eta()) > etaMix) {
if (lambdaTag3 && (lambda2.M() < lbinIM || lambda2.M() > hbinIM)) {
continue;
}
if (mixingCombination == 0 && std::abs(t1.phi() - t3.phi()) > phiMix) {
if (aLambdaTag3 && (antiLambda2.M() < lbinIM || antiLambda2.M() > hbinIM)) {
continue;
}
double deltaPhiMix = RecoDecay::constrainAngle(t3.phi() - t2.phi(), 0.0);
auto mixPairR = TMath::Sqrt(TMath::Power(deltaPhiMix, 2.0) + TMath::Power(t3.eta() - t2.eta(), 2.0));

Check failure on line 720 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
auto etaDiff = t1.eta() - t3.eta();
auto phiDiff = RecoDecay::constrainAngle(t1.phi() - t3.phi(), 0.0);

if (mixingCombination == 1 && std::abs(mixPairSumPt - samePairSumPt) > ptMix) {
histos.fill(HIST("hPtDiff"), t1.pt() - t3.pt());
histos.fill(HIST("hPhiDiff"), phiDiff);
histos.fill(HIST("hRDiff"), etaDiff);

if (mixingCombination == 0 && std::abs(t1.pt() - t3.pt()) > ptMix) {
continue;
}
if (mixingCombination == 1 && std::abs(mixPairR - samePairR) > etaMix) {
if (mixingCombination == 0 && t1.eta() * t3.eta() > 0 && std::abs(etaDiff) > etaMix) {
continue;
}
if (lambdaTag2) {
proton = ROOT::Math::PxPyPzMVector(t2.pxpos(), t2.pypos(), t2.pzpos(), o2::constants::physics::MassProton);
antiPion = ROOT::Math::PxPyPzMVector(t2.pxneg(), t2.pyneg(), t2.pzneg(), o2::constants::physics::MassPionCharged);
lambda = proton + antiPion;
}
if (aLambdaTag2) {
antiProton = ROOT::Math::PxPyPzMVector(t2.pxneg(), t2.pyneg(), t2.pzneg(), o2::constants::physics::MassProton);
pion = ROOT::Math::PxPyPzMVector(t2.pxpos(), t2.pypos(), t2.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda = antiProton + pion;
if (mixingCombination == 0 && phiDiff > phiMix) {
continue;
}
if (lambdaTag3) {
proton2 = ROOT::Math::PxPyPzMVector(t3.pxpos(), t3.pypos(), t3.pzpos(), o2::constants::physics::MassProton);
antiPion2 = ROOT::Math::PxPyPzMVector(t3.pxneg(), t3.pyneg(), t3.pzneg(), o2::constants::physics::MassPionCharged);
lambda2 = proton2 + antiPion2;

if (mixingCombination == 1 && std::abs(t1.pt() - t3.pt()) > ptMix) {
continue;
}
if (aLambdaTag3) {
antiProton2 = ROOT::Math::PxPyPzMVector(t3.pxneg(), t3.pyneg(), t3.pzneg(), o2::constants::physics::MassProton);
pion2 = ROOT::Math::PxPyPzMVector(t3.pxpos(), t3.pypos(), t3.pzpos(), o2::constants::physics::MassPionCharged);
antiLambda2 = antiProton2 + pion2;
if (mixingCombination == 1 && std::abs(mixPairR - samePairR) > etaMix) {
continue;
}

if (lambdaTag2 && lambdaTag3) {
fillHistograms(1, 0, 1, 0, lambda, lambda2, proton, proton2, centrality, 2);
} else if (aLambdaTag2 && aLambdaTag3) {
Expand All @@ -714,7 +754,6 @@
continue;
}
pairfound = true;
// pairStatus[t3.index()][t2.index()] = true;
pairStatus[t3.index()][t2.index()] = true;
// LOGF(info, "v0 id: (%d, %d)", t3.index(), t2.index());
if (pairfound) {
Expand Down Expand Up @@ -810,7 +849,7 @@
// Processing Event Mixing MC
void processMEMC(CollisionMCRecTableCentFT0C const& collisions, TrackMCRecTable const&, V0TrackCandidatesMC const& V0s)
{
for (auto& [collision1, collision2] : selfCombinations(colBinning, nMix, -1, collisions, collisions)) {

Check failure on line 852 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
// LOGF(info, "Mixed event collisions: (%d, %d)", collision1.index(), collision2.index());

if (collision1.index() == collision2.index()) {
Expand All @@ -837,7 +876,7 @@
continue;
}
bool pairStatus[1150][1150] = {{false}};
for (auto& [t1, t2] : soa::combinations(o2::soa::CombinationsFullIndexPolicy(groupV01, groupV02))) {

Check failure on line 879 in PWGLF/Tasks/Strangeness/taskLambdaSpinCorr.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
bool pairfound = false;
if (t2.index() <= t1.index()) {
continue;
Expand Down
Loading