Skip to content

[PWGHF] Add UPC event selection #11518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 22 commits into from
Jun 27, 2025
Merged

[PWGHF] Add UPC event selection #11518

fgrosa merged 22 commits into from
Jun 27, 2025

Conversation

@zhangbiao-phy
Copy link
Collaborator

@zhangbiao-phy zhangbiao-phy commented Jun 9, 2025 •
edited
Loading

Add UPC event selection into the HF framework, the preselection used taken from UD group, further selection (ZDC or ITs UPC mode) can be easily added into specific task:

  • Implement SGSelector cut from PWGUD
  • Add rejection bit into rejection mask
  • Add QA plot for the type of single gap A/C, double gap trigger event

Main changes are in trackIndexSkimCreator.cxx and utilsEvSelHf.h

image

@github-actions github-actions bot added the pwghf PWG-HF label Jun 9, 2025
@github-actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

O2 linter results: ❌ 20 errors, ⚠️ 0 warnings, 🔕 47 disabled

@alibuild alibuild mentioned this pull request Jun 9, 2025
Merged
zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025
@zhangbiao-phy
Merge pull request #40 from alibuild/alibot-cleanup-11518
88ba97e 
[PWGHF] Please consider the following formatting changes to AliceO2Group#11518
@alibuild alibuild mentioned this pull request Jun 9, 2025
Merged
zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025
@zhangbiao-phy
Merge pull request #41 from alibuild/alibot-cleanup-11518
624059a 
Please consider the following formatting changes to AliceO2Group#11518
@alibuild alibuild mentioned this pull request Jun 9, 2025
Merged
zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025
@zhangbiao-phy
Merge pull request #42 from alibuild/alibot-cleanup-11518
71fc7b5 
[PWGHF] Please consider the following formatting changes to AliceO2Group#11518
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review June 9, 2025 11:58
@alibuild
Copy link
Collaborator

alibuild commented Jun 9, 2025

Error while checking build/O2Physics/o2 for 71fc7b5 at 2025-06-09 17:20:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
collect2: error: ld returned 1 exit status
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jun 9, 2025
Merged
zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025
@zhangbiao-phy
Merge pull request #43 from alibuild/alibot-cleanup-11518
ead0914 
[PWGHF] Please consider the following formatting changes to AliceO2Group#11518
mfaggin
mfaggin reviewed Jun 9, 2025
View reviewed changes
PWGHF/Utils/utilsEvSelHf.h Outdated
o2::framework::Configurable<float> centralityMin{"centralityMin", 0., "Minimum centrality"};
o2::framework::Configurable<float> centralityMax{"centralityMax", 100., "Maximum centrality"};
o2::framework::Configurable<bool> useSel8Trigger{"useSel8Trigger", true, "Apply the sel8 event selection"};
o2::framework::Configurable<bool> useUpcTrigger{"useUpcTrigger", true, "Apply the upc event selection"};
Copy link
Collaborator

@mfaggin mfaggin Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
o2::framework::Configurable<bool> useUpcTrigger{"useUpcTrigger", true, "Apply the upc event selection"};
o2::framework::Configurable<bool> useUpcTrigger{"useUpcTrigger", false, "Apply the upc event selection"};

I'd not enable it by default

Copy link
Collaborator Author

@zhangbiao-phy zhangbiao-phy Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spoting this

PWGHF/Tasks/taskMcValidation.cxx Outdated
aod::McParticles const& mcParticles,
aod::McCollisions const& mcCollisions,
aod::BCsWithTimestamps const& bcs,
BCsInfo const& bcs,
Copy link
Collaborator

@mfaggin mfaggin Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call the BCsInfo data type if and only if UPC selections are enabled. This means that in the process functions that do not apply UPC selections I'd not use at all the data type BCsInfo, but I'd keep the data type aod::BCsWithTimestamps

vkucera
vkucera requested changes Jun 9, 2025
View reviewed changes
@vkucera vkucera changed the title [PWGHF] Add upc selection into HF framework [PWGHF] Add UPC event selection Jun 26, 2025
vkucera
vkucera reviewed Jun 26, 2025
View reviewed changes
vkucera
vkucera reviewed Jun 26, 2025
View reviewed changes
vkucera
vkucera reviewed Jun 26, 2025
View reviewed changes
vkucera
vkucera reviewed Jun 26, 2025
View reviewed changes
vkucera
vkucera reviewed Jun 26, 2025
View reviewed changes
vkucera
vkucera reviewed Jun 26, 2025
View reviewed changes
@alibuild alibuild mentioned this pull request Jun 26, 2025
Merged
zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 26, 2025
@zhangbiao-phy
Merge pull request #60 from alibuild/alibot-cleanup-11518
35f7461 
[PWGHF] Please consider the following formatting changes to AliceO2Group#11518
@alibuild alibuild mentioned this pull request Jun 26, 2025
Merged
@vkucera vkucera enabled auto-merge (squash) June 26, 2025 14:33
@vkucera
Copy link
Collaborator

vkucera commented Jun 26, 2025 •
edited
Loading

@mfaggin @fgrosa Can you also check if it looks good to you?

@vkucera vkucera disabled auto-merge June 26, 2025 14:34
@fgrosa
Copy link
Collaborator

fgrosa commented Jun 27, 2025

@mfaggin @fgrosa Can you also check if it looks good to you?

Good for me! I would suggest to move on and merge

@fgrosa fgrosa merged commit 5e04fa8 into AliceO2Group:master Jun 27, 2025
13 of 14 checks passed
@zhangbiao-phy
Copy link
Collaborator Author

zhangbiao-phy commented Jun 27, 2025

@mfaggin @fgrosa Can you also check if it looks good to you?

Good for me! I would suggest to move on and merge

Thanks all!

jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@zhangbiao-phy @alibuild @jpxrk
[PWGHF] Add UPC event selection (AliceO2Group#11518)
bd3ffeb 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@zhangbiao-phy @alibuild
[PWGHF] Add UPC event selection (AliceO2Group#11518)
ee9fd7a 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@zhangbiao-phy @alibuild
[PWGHF] Add UPC event selection (AliceO2Group#11518)
4b636b6 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@zhangbiao-phy @alibuild @vojmach
[PWGHF] Add UPC event selection (AliceO2Group#11518)
0b54b3f 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@zhangbiao-phy @alibuild @jloemker
[PWGHF] Add UPC event selection (AliceO2Group#11518)
a375fc0 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfaggin mfaggin mfaggin left review comments

@vkucera vkucera vkucera approved these changes

@fgrosa fgrosa fgrosa left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhangbiao-phy @alibuild @fgrosa @vkucera @mfaggin