Skip to content

Conversation

@creetz16
Copy link
Contributor

@creetz16 creetz16 commented Jun 8, 2025

@github-actions
Copy link

github-actions bot commented Jun 8, 2025

O2 linter results: ❌ 122 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title [PWGLF]: Update hypertriton 3body decay analysis [PWGLF] Update hypertriton 3body decay analysis Jun 8, 2025
@creetz16 creetz16 marked this pull request as ready for review June 8, 2025 20:42
@maciacco
Copy link
Collaborator

maciacco commented Jun 9, 2025

@creetz16 maybe consider these two improvements from megalinter:

  PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:596:  Add #include <memory> for shared_ptr<>  [build/include_what_you_use] [4]
  PWGLF/Utils/decay3bodyBuilderHelper.h:838:  #endif line should be "#endif  // PWGLF_UTILS_DECAY3BODYBUILDERHELPER_H_"  [build/header_guard] [5]

Also check instances where you miss the std:: prefix (the O2Linter output might be useful for this).

@maciacco maciacco enabled auto-merge (squash) June 10, 2025 08:28
@maciacco
Copy link
Collaborator

@skundu692 could you have a look to this PR?

@maciacco maciacco merged commit 2fd49aa into AliceO2Group:master Jun 12, 2025
13 of 14 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lietava pushed a commit to lietava/O2Physics that referenced this pull request Jun 14, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@creetz16 creetz16 deleted the h3l-helper branch June 26, 2025 13:59
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants