Skip to content

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Jun 6, 2025

  • adds a task to tentatively replace mult/cent services with a single, self-configuring, lightweight device following the rationale of the strangenessbuilder. Track loops / slices replaced by single operations for faster operation in all processing paths.
  • now with run 2 and run 3 modes tested thanks to @romainschotter. Still some tuning to be done with defineDataProcessing autodetect, but will follow in separate PR.

@github-actions github-actions bot added the common label Jun 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

O2 linter results: ❌ 32 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ddobrigk
Copy link
Collaborator Author

ddobrigk commented Jun 6, 2025

Tagging @romainschotter - whenever you have a moment, please help me with testing

Tagging @iarsene - this should provide a measurable reduction in memory footprint but you should only use this once it is working and has been confirmed to lead to the same output as the legacy tasks

Some further features to be added:

  • bc-based centrality
  • Run 2 style truncation for anchor point calculation

@ddobrigk
Copy link
Collaborator Author

ddobrigk commented Jun 7, 2025

@fjonasALICE @nstrangm this PR will provide a unified mult/cent task that will include BC-level centrality values for FT0 signals and, while at it, it will simplify the task, using less memory and less CPU. I will finish some testing soon and then move the PR to review, but even then, since this is intended to be a replacement for multiplicityTable and centralityTable, we'll have to commission it a bit. Hope this helps!

@romainschotter
Copy link
Collaborator

To make sure that the multiplicity/centrality tasks and the new multCentTable task produce the same centrality distribution, here is a comparison of the centrality distribution produced by those tasks in real data, in MC data and in Run2 converted data:
ComparisonRealData
ComparisonMCData
ComparisonRun2

As you can see, the new multCentTable task produces the same results as the multiplicity/centrality tasks

@ddobrigk
Copy link
Collaborator Author

We're still missing the autodetect at defineDataProcessing but let's move this to review and take care of that extra feature later. Might still do a little cleanup etc before going ahead

@ddobrigk ddobrigk marked this pull request as ready for review June 12, 2025 14:57
@ddobrigk ddobrigk requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners June 12, 2025 14:57
@ddobrigk ddobrigk enabled auto-merge (squash) June 12, 2025 19:47
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk merged commit ac79075 into AliceO2Group:master Jun 13, 2025
15 of 18 checks passed
ddobrigk added a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
…liceO2Group#11495)

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Co-authored-by: romainschotter <romain.schotter@gmail.com>
Co-authored-by: SCHOTTER Romain <47983209+romainschotter@users.noreply.github.com>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
…liceO2Group#11495)

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Co-authored-by: romainschotter <romain.schotter@gmail.com>
Co-authored-by: SCHOTTER Romain <47983209+romainschotter@users.noreply.github.com>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
…liceO2Group#11495)

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Co-authored-by: romainschotter <romain.schotter@gmail.com>
Co-authored-by: SCHOTTER Romain <47983209+romainschotter@users.noreply.github.com>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
…liceO2Group#11495)

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Co-authored-by: romainschotter <romain.schotter@gmail.com>
Co-authored-by: SCHOTTER Romain <47983209+romainschotter@users.noreply.github.com>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…liceO2Group#11495)

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Co-authored-by: romainschotter <romain.schotter@gmail.com>
Co-authored-by: SCHOTTER Romain <47983209+romainschotter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants