Skip to content

Conversation

@Luzhiyongg
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title add MC process [PWGCF] add MC process Jun 5, 2025
Filter particleFilter = (nabs(aod::mcparticle::eta) < cfgCutEta) && (aod::mcparticle::pt > cfgCutPtMin) && (aod::mcparticle::pt < cfgCutPtMax);
using FilteredMcParticles = soa::Filtered<aod::McParticles>;

using FilteredSmallGroupMcCollisions = soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSel, aod::CentFT0Cs, aod::CentFT0CVariant1s, aod::CentFT0Ms, aod::CentFV0As, aod::Mults>>;
Copy link
Collaborator

@victor-gonzalez victor-gonzalez Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with the naming! So far, nothing is filtered in here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victor, I may make a mistake, but doesn't SmallGroups always include soa::Filtered?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victor, I may make a mistake, but doesn't SmallGroups always include soa::Filtered?

Well, if they are not on Filtered tables, they shouldn't

using MyMcCollisions = soa::Filtered<aod::McCollisions>;
using FilteredMcCollisions = soa::Filtered<aod::McCollisions>;

using FilteredSmallGroupMcCollisions = soa::SmallGroups<soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSel, aod::CentFT0Cs, aod::CentFT0CVariant1s, aod::CentFT0Ms, aod::CentFV0As, aod::Mults>>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at my comment in case you want to consider it for next iterations

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) June 5, 2025 20:27
@victor-gonzalez victor-gonzalez merged commit e4e94eb into AliceO2Group:master Jun 5, 2025
15 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants