-
Notifications
You must be signed in to change notification settings - Fork 614
[Common,ALICE3,PWGLF,PWGUD,DPG,Tutorial] Import system libraries using angle brackets #11454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 2363 errors, |
njacazio
approved these changes
Jun 3, 2025
vkucera
approved these changes
Jun 3, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @singiamtel !
Approving just formally since PWGHF is clean. ;-)
I would be in favour of adding it in the CI.
@ddobrigk What do you think?
rolavick
approved these changes
Jun 3, 2025
romainschotter
approved these changes
Jun 3, 2025
ddobrigk
approved these changes
Jun 6, 2025
altsybee
approved these changes
Jun 6, 2025
pbuehler
approved these changes
Jun 6, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 11, 2025
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Jun 11, 2025
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Jun 12, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 12, 2025
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jul 16, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this with some bash helper script, TBD if it's worth it to add to the CI
https://gist.github.com/singiamtel/9c728b4adeb4bee0a2c7d34d56d4a507
CC @vkucera @ktf