Skip to content

[PWGUD] Improving correlation for gap sides #11435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolavick merged 45 commits into from
Jun 5, 2025
Merged

[PWGUD] Improving correlation for gap sides #11435

rolavick merged 45 commits into from
Jun 5, 2025

Conversation

@JosueMtzGar
Copy link
Contributor

@JosueMtzGar JosueMtzGar commented Jun 2, 2025

No description provided.

JosueMtzGar added 30 commits May 9, 2024 14:59
@JosueMtzGar
improving the analysis
fc80f61
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
25763be
@JosueMtzGar
improving the analysis
4cae5d6
@JosueMtzGar
new changes
7f09d3d
@JosueMtzGar
new changes
d854bdd
@JosueMtzGar
Merge remote-tracking branch 'upstream/master' into localtestPWGUD
b33a3b6
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
4ad5488
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
ecaad17
@JosueMtzGar
adding angular correlation analysis
7234a79
@JosueMtzGar
saving the last changes
2768e38
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
63d8c61
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
b18cd8e
@JosueMtzGar
adding helper to pair cuts for UD tables
03cd5be
@JosueMtzGar
new changes
62739d2
@JosueMtzGar
new changes, using correlation container. output object empty
907fc67
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
3101f1c
@JosueMtzGar
probe of correlation container tutorial
c463936
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
3e45828
@JosueMtzGar
a little change to test
ddd1083
@JosueMtzGar
recent changes on the correlation analysis, container still empty
81251f2
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
d257ef9
@JosueMtzGar
saving updates to change to Lumi work
35e7ea8
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
4768865
@JosueMtzGar
new changes
48cd940
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
ad7514f
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
0154bcf
@JosueMtzGar
new changes to do correlations
1dff562
@JosueMtzGar
Merge branch 'master' into localtestPWGUD
7114730
@JosueMtzGar
formatting issues
5a137f4
@JosueMtzGar
formatting issues
5b6cd2a
@github-actions github-actions bot added the pwgud label Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

O2 linter results: ❌ 21 errors, ⚠️ 0 warnings, 🔕 0 disabled

@JosueMtzGar JosueMtzGar marked this pull request as ready for review June 2, 2025 11:44
@alibuild
Copy link
Collaborator

alibuild commented Jun 2, 2025

Error while checking build/O2Physics/o2 for 74a7be9 at 2025-06-02 16:40:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11435-slc9_x86-64/0/PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx:169:15: error: redeclaration of 'UPCPairCuts upcPhotonuclearAnalysisJMG::mPairCuts'
/sw/SOURCES/O2Physics/11435-slc9_x86-64/0/PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx:170:21: error: redeclaration of 'bool upcPhotonuclearAnalysisJMG::doPairCuts'
/sw/SOURCES/O2Physics/11435-slc9_x86-64/0/PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx:605:9: error: unused variable 'sgSide' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@JosueMtzGar JosueMtzGar marked this pull request as draft June 2, 2025 18:12
@JosueMtzGar JosueMtzGar marked this pull request as ready for review June 3, 2025 06:44
@JosueMtzGar
Copy link
Contributor Author

JosueMtzGar commented Jun 4, 2025

Dear reviewers,
could you please take a look at this PR? I’d really appreciate your review and approval if everything looks good, Thanks in advance!

rolavick
rolavick requested changes Jun 4, 2025
View reviewed changes
@rolavick rolavick enabled auto-merge (squash) June 5, 2025 08:48
@rolavick rolavick merged commit 7a52269 into AliceO2Group:master Jun 5, 2025
13 of 14 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@JosueMtzGar @jinhyunni
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
96c5228
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@JosueMtzGar
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
94750e1
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
@JosueMtzGar @EmilGorm
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
13dc0a6
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@JosueMtzGar
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
f8d8801
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@JosueMtzGar
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
0bf26df
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@JosueMtzGar @smaff92
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
9ff5187
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@JosueMtzGar @romainschotter
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
498c109
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@JosueMtzGar @CesarOmarRA
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
1d354d0
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@JosueMtzGar @jloemker
[PWGUD] Improving correlation for gap sides (AliceO2Group#11435)
59e2d4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolavick rolavick rolavick approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler

@abylinkin abylinkin Awaiting requested review from abylinkin

Assignees

No one assigned

Labels

pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JosueMtzGar @alibuild @rolavick