-
Notifications
You must be signed in to change notification settings - Fork 622
[PWGCF,PWGEM,PWGLF] Replace expression columns with dynamic columns in strangeness data model #11420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 839 errors, |
Please consider the following formatting changes to AliceO2Group#11420
PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx
Outdated
Show resolved
Hide resolved
|
Hi @romainschotter, thanks a lot for taking care of this! I hope you don't mind - I took the liberty of commenting inline (just for convenience). For reference: the removal of the expression column spawning will reduce the memory footprint further by approximately 60MB, which, at a time in which memory in core services is a commodity, is a very good thing :-) |
[PWGLF] Please consider the following formatting changes to AliceO2Group#11420
|
Regarding the changes in CF code, @JStaa (the author of the |
|
Error while checking build/O2Physics/o2 for fcc22e3 at 2025-06-02 17:50: Full log here. |
|
@saganatt @victor-gonzalez @zchochul @lgraczykCern @prchakra @lauraser @ariedel-cern @EmilGorm @otonvd @shouqiye @glromane can you please have a look at the changes in the PWGCF directory and approve them if they look okay to you? @JStaa (the author of the |
|
Thanks @romainschotter!!! |
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…n strangeness data model (AliceO2Group#11420) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Replace expression columns to dynamic columns in the strangeness data model.
Within the strangeness framework, expression columns appear only in extended tables and, more particularly, in the tables V0Cores, V0fCCores, CascCores , KFCascCores and TraCascCores. In order to ensure backwards compatibility, the extended tables (V0Cores, V0fCCores, CascCores , KFCascCores and TraCascCores) have been replaced to aliases to standard tables (V0CoresBase, StoredV0fCCores, StoredCascCores, StoredKFCascCores and StoredTraCascCores respectively) and the previously existing expression columns have been added as dynamic columns to the aforementioned standard tables.
This has several consequences:
Filterusing one of the above tables have to replaced by imperative-if conditions,In order to make sure that analysis results remain unchanged after those changes, here is a comparison of the invariant mass distribution of K0s in Pb-Pb at 5.36 TeV (with 1 file of run 544116) obtained using a O2Physics installation with the expression columns in the strangeness data model in full black circles and without them in open red circles.

As you can see, the results are exactly the same before and after the changes.
@ddobrigk, for your information