Skip to content

Conversation

@romainschotter
Copy link
Collaborator

@romainschotter romainschotter commented May 30, 2025

Replace expression columns to dynamic columns in the strangeness data model.
Within the strangeness framework, expression columns appear only in extended tables and, more particularly, in the tables V0Cores, V0fCCores, CascCores , KFCascCores and TraCascCores. In order to ensure backwards compatibility, the extended tables (V0Cores, V0fCCores, CascCores , KFCascCores and TraCascCores) have been replaced to aliases to standard tables (V0CoresBase, StoredV0fCCores, StoredCascCores, StoredKFCascCores and StoredTraCascCores respectively) and the previously existing expression columns have been added as dynamic columns to the aforementioned standard tables.
This has several consequences:

  • as dynamic columns cannot be used for filtering, all Filter using one of the above tables have to replaced by imperative-if conditions,
  • as there are no more expression columns, there is no need to spawn the extended tables and for spawner tasks anymore, thus allowing to reduce the memory consumption by 50MB.

In order to make sure that analysis results remain unchanged after those changes, here is a comparison of the invariant mass distribution of K0s in Pb-Pb at 5.36 TeV (with 1 file of run 544116) obtained using a O2Physics installation with the expression columns in the strangeness data model in full black circles and without them in open red circles.
ComparisonWithAndWithoutExpColumns
As you can see, the results are exactly the same before and after the changes.

@ddobrigk, for your information

@github-actions
Copy link

github-actions bot commented May 30, 2025

O2 linter results: ❌ 839 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Replace expression columns to dynamic columns in strangeness data model [PWGCF,PWGEM,PWGLF] Replace expression columns to dynamic columns in strangeness data model May 30, 2025
romainschotter added a commit to romainschotter/O2Physics that referenced this pull request May 31, 2025
Please consider the following formatting changes to AliceO2Group#11420
@ddobrigk
Copy link
Collaborator

Hi @romainschotter, thanks a lot for taking care of this! I hope you don't mind - I took the liberty of commenting inline (just for convenience).

For reference: the removal of the expression column spawning will reduce the memory footprint further by approximately 60MB, which, at a time in which memory in core services is a commodity, is a very good thing :-)

[PWGLF] Please consider the following formatting changes to AliceO2Group#11420
@ddobrigk ddobrigk changed the title [PWGCF,PWGEM,PWGLF] Replace expression columns to dynamic columns in strangeness data model [PWGCF,PWGEM,PWGLF] Replace expression columns with dynamic columns in strangeness data model Jun 1, 2025
@romainschotter romainschotter marked this pull request as ready for review June 2, 2025 14:42
@romainschotter
Copy link
Collaborator Author

Regarding the changes in CF code, @JStaa (the author of the threeParticleCorrelations.cxx task) has reviewed and agreed with the modifications introduced in this PR.

dsekihat
dsekihat previously approved these changes Jun 2, 2025
@alibuild
Copy link
Collaborator

alibuild commented Jun 2, 2025

Error while checking build/O2Physics/o2 for fcc22e3 at 2025-06-02 17:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11420-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx:884:9: error: 'v0' was not declared in this scope; did you mean 'o2::aod::v0'?
/sw/SOURCES/O2Physics/11420-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx:886:18: error: 'v0' was not declared in this scope; did you mean 'o2::aod::v0'?
ninja: build stopped: subcommand failed.

Full log here.

@romainschotter
Copy link
Collaborator Author

@saganatt @victor-gonzalez @zchochul @lgraczykCern @prchakra @lauraser @ariedel-cern @EmilGorm @otonvd @shouqiye @glromane can you please have a look at the changes in the PWGCF directory and approve them if they look okay to you? @JStaa (the author of the threeParticleCorrelations.cxx task) has reviewed and agreed with the modifications introduced in this PR.
@dsekihat can you please re-approve the changes? Somehow, Github introduced an error when merging my fork with the master branch.

@victor-gonzalez
Copy link
Collaborator

Thanks @romainschotter!!!

@ddobrigk ddobrigk merged commit 0de7f1c into AliceO2Group:master Jun 4, 2025
12 of 15 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…n strangeness data model (AliceO2Group#11420)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants