Skip to content

[PWGHF] Add ML selection for Xic0ToXiPiKf #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 31 commits into from
Jun 3, 2025
Merged

[PWGHF] Add ML selection for Xic0ToXiPiKf #11388

fgrosa merged 31 commits into from
Jun 3, 2025

Conversation

@Tao-Fang
Copy link
Contributor

@Tao-Fang Tao-Fang commented May 28, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add MlSelection at candidateSelectorXic0ToXiPiKf.cxx and uplode HfMlResponseXicToXiPikf.h [PWGHF] Add MlSelection at candidateSelectorXic0ToXiPiKf.cxx and uplode HfMlResponseXicToXiPikf.h May 28, 2025
@alibuild alibuild mentioned this pull request May 28, 2025
Merged
@Tao-Fang Tao-Fang marked this pull request as ready for review May 28, 2025 08:53
vkucera
vkucera requested changes May 28, 2025
View reviewed changes
vkucera
vkucera requested changes May 28, 2025
View reviewed changes
vkucera
vkucera requested changes May 30, 2025
View reviewed changes
@vkucera vkucera marked this pull request as draft May 30, 2025 16:20
@Tao-Fang Tao-Fang marked this pull request as ready for review May 31, 2025 07:13
@alibuild
Copy link
Collaborator

alibuild commented May 31, 2025

Error while checking build/O2Physics/o2 for 0bcbba3 at 2025-05-31 09:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: no matching function for call to 'std::vector<double>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: could not convert '{"binsPtMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: no matching function for call to 'std::vector<int>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: could not convert '{"cutDirMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<int> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:56: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:77: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:98: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:122: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:144: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:199: error: could not convert '{"cutsMl", {<expression error>, <expression error>, <expression error>, <expression error>, <expression error>}, "ML selections per pT bin"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:63: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:119: error: could not convert '{"nClassesMl", <expression error>, "Number of classes in ML model"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<int>'
/sw/slc9_x86-64/O2/daily-20250531-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(HfCandidateSelectorXic0ToXiPiKf*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 31, 2025

Error while checking build/O2Physics/o2 for b0c4a5f at 2025-05-31 12:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: no matching function for call to 'std::vector<double>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: could not convert '{"binsPtMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: no matching function for call to 'std::vector<int>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: could not convert '{"cutDirMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<int> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:56: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:77: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:98: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:122: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:144: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:199: error: could not convert '{"cutsMl", {<expression error>, <expression error>, <expression error>, <expression error>, <expression error>}, "ML selections per pT bin"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:63: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:119: error: could not convert '{"nClassesMl", <expression error>, "Number of classes in ML model"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<int>'
/sw/slc9_x86-64/O2/daily-20250531-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(HfCandidateSelectorXic0ToXiPiKf*&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft May 31, 2025 12:01
@Tao-Fang Tao-Fang marked this pull request as ready for review June 2, 2025 11:14
@alibuild
Copy link
Collaborator

alibuild commented Jun 2, 2025

Error while checking build/O2Physics/o2 for 3dbd992 at 2025-06-02 15:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: no matching function for call to 'std::vector<double>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: could not convert '{"binsPtMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: no matching function for call to 'std::vector<int>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: could not convert '{"cutDirMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<int> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:56: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:77: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:98: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:122: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:144: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:199: error: could not convert '{"cutsMl", {<expression error>, <expression error>, <expression error>, <expression error>, <expression error>}, "ML selections per pT bin"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:63: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:119: error: could not convert '{"nClassesMl", <expression error>, "Number of classes in ML model"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<int>'
/sw/slc9_x86-64/O2/daily-20250602-0000-local2/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(HfCandidateSelectorXic0ToXiPiKf*&)'
ninja: build stopped: subcommand failed.

Full log here.

@Tao-Fang Tao-Fang requested a review from vkucera June 3, 2025 07:01
vkucera
vkucera approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tao-Fang for addressing my comments.

@fgrosa fgrosa enabled auto-merge (squash) June 3, 2025 12:18
@fgrosa fgrosa merged commit 754dcbf into AliceO2Group:master Jun 3, 2025
14 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@Tao-Fang @alibuild
@vkucera @jinhyunni
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
6072536 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@Tao-Fang @alibuild @vkucera
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
f67e433 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
@Tao-Fang @alibuild
@vkucera @EmilGorm
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
9f9db9e 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@Tao-Fang @alibuild @vkucera
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
068effd 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@Tao-Fang @alibuild @vkucera
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
ed911d3 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@Tao-Fang @alibuild
@vkucera @smaff92
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
5d12ca0 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@Tao-Fang @alibuild
@vkucera @romainschotter
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
9ed72d1 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@Tao-Fang @alibuild
@vkucera @CesarOmarRA
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
d110d91 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Tao-Fang @alibuild
@vkucera @jloemker
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
c5485b1 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tao-Fang @alibuild @vkucera @fgrosa