Skip to content

[PWGCF] add configurable mult cut #11379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
victor-gonzalez merged 6 commits into from
May 30, 2025
Merged

[PWGCF] add configurable mult cut #11379

victor-gonzalez merged 6 commits into from
May 30, 2025

Conversation

@EmilGorm
Copy link
Contributor

@EmilGorm EmilGorm commented May 27, 2025

  • add b axis for OTF
  • add configurables for more track cuts

@github-actions github-actions bot added the pwgcf label May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title add configurable mult cut [PWGCF] add configurable mult cut May 27, 2025
@alibuild alibuild mentioned this pull request May 27, 2025
Merged
EmilGorm added a commit to EmilGorm/O2Physics that referenced this pull request May 27, 2025
@EmilGorm
Merge pull request #19 from alibuild/alibot-cleanup-11379
e14b4a1 
[PWGCF] Please consider the following formatting changes to AliceO2Group#11379
@EmilGorm EmilGorm marked this pull request as ready for review May 27, 2025 11:26
@alibuild
Copy link
Collaborator

alibuild commented May 27, 2025

Error while checking build/O2Physics/o2 for e14b4a1 at 2025-05-27 15:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11379-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:1083:20: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/11379-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:266:32: error: this statement may fall through [-Werror=implicit-fallthrough=]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request May 27, 2025
Closed
victor-gonzalez
victor-gonzalez reviewed May 27, 2025
View reviewed changes
PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx
Comment on lines +390 to +398
fMultPVCutLow = new TF1("fMultPVCutLow", "[0]+[1]*x+[2]*x*x+[3]*x*x*x+[4]*x*x*x*x - 3.5*([5]+[6]*x+[7]*x*x+[8]*x*x*x+[9]*x*x*x*x)", 0, 100);
fMultPVCutLow->SetParameters(3257.29, -121.848, 1.98492, -0.0172128, 6.47528e-05, 154.756, -1.86072, -0.0274713, 0.000633499, -3.37757e-06);
fMultPVCutHigh = new TF1("fMultPVCutHigh", "[0]+[1]*x+[2]*x*x+[3]*x*x*x+[4]*x*x*x*x + 3.5*([5]+[6]*x+[7]*x*x+[8]*x*x*x+[9]*x*x*x*x)", 0, 100);
fMultPVCutHigh->SetParameters(3257.29, -121.848, 1.98492, -0.0172128, 6.47528e-05, 154.756, -1.86072, -0.0274713, 0.000633499, -3.37757e-06);
fMultCutLow = new TF1("fMultCutLow", "[0]+[1]*x+[2]*x*x+[3]*x*x*x - 2.*([4]+[5]*x+[6]*x*x+[7]*x*x*x+[8]*x*x*x*x)", 0, 100);
fMultCutLow->SetParameters(1654.46, -47.2379, 0.449833, -0.0014125, 150.773, -3.67334, 0.0530503, -0.000614061, 3.15956e-06);
fMultCutHigh = new TF1("fMultCutHigh", "[0]+[1]*x+[2]*x*x+[3]*x*x*x + 3.*([4]+[5]*x+[6]*x*x+[7]*x*x*x+[8]*x*x*x*x)", 0, 100);
fMultCutHigh->SetParameters(1654.46, -47.2379, 0.449833, -0.0014125, 150.773, -3.67334, 0.0530503, -0.000614061, 3.15956e-06); */
Copy link
Collaborator

@victor-gonzalez victor-gonzalez May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember not leaving commented code for the next iterations

victor-gonzalez
victor-gonzalez approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider my comment for future iteractions

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) May 27, 2025 19:46
@victor-gonzalez victor-gonzalez merged commit 5c2cfbf into AliceO2Group:master May 30, 2025
14 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@EmilGorm @jinhyunni
[PWGCF] add configurable mult cut (AliceO2Group#11379)
5b36c17
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@EmilGorm
[PWGCF] add configurable mult cut (AliceO2Group#11379)
18655f9
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@EmilGorm
[PWGCF] add configurable mult cut (AliceO2Group#11379)
bb04777
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@EmilGorm
[PWGCF] add configurable mult cut (AliceO2Group#11379)
22e7c0c
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@EmilGorm @smaff92
[PWGCF] add configurable mult cut (AliceO2Group#11379)
a578871
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@EmilGorm @romainschotter
[PWGCF] add configurable mult cut (AliceO2Group#11379)
de7707f
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@EmilGorm @CesarOmarRA
[PWGCF] add configurable mult cut (AliceO2Group#11379)
17dfa60
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@EmilGorm @jloemker
[PWGCF] add configurable mult cut (AliceO2Group#11379)
b33c125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmilGorm @alibuild @victor-gonzalez