Skip to content

Conversation

@fchinu
Copy link
Contributor

@fchinu fchinu commented May 26, 2025

This PR adds the reduced workflows for the B+ and B0s meson analyses for their decays into a J/Psi and a K+ and phi, respectively. The considered decay of the J/Psi is that into a muon pair at midrapidity, and this workflow is meant to be used for the newly-developed HF software triggers for 2025 pp data taking. A runJPsiToee is also available in order to validate the workflow using the already existing MC simulations of B -> J/Psi X -> ee X.
In a following PR the workflow of B0 -> J/psi K*(892)0 -> (µµ) (Kpi) will be added, following what was done for the B0s -> J/Psi phi -> (µµ)(KK) workflow.

@github-actions
Copy link

github-actions bot commented May 26, 2025

O2 linter results: ❌ 29 errors, ⚠️ 0 warnings, 🔕 37 disabled

@github-actions github-actions bot changed the title Add reduced workflow for B+, B0s -> J/Psi X analyses [PWGHF] Add reduced workflow for B+, B0s -> J/Psi X analyses May 26, 2025
@vkucera vkucera marked this pull request as draft May 26, 2025 15:32
@fchinu
Copy link
Contributor Author

fchinu commented May 26, 2025

I would not feel super comfortable in fixing the O2 linter error
error: Workflow name task-omegac0-to-omega-pi does not match its file name taskOmegac0ToOmegapi.cxx, but of course if would you like me to do something in this PR I can do it, if the Omegac analysers are okay with that!

@vkucera
Copy link
Collaborator

vkucera commented May 26, 2025

I would not feel super comfortable in fixing the O2 linter error error: Workflow name task-omegac0-to-omega-pi does not match its file name taskOmegac0ToOmegapi.cxx, but of course if would you like me to do something in this PR I can do it, if the Omegac analysers are okay with that!

That's OK. That error is unrelated to your code and PR. Thanks for fixing the rest.

Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fchinu thanks a lot for the developments! I have checked everything except for the tasks, since there are a few "major" things to change first I think.
For the tasks instead, we could even consider to have a combined one (but maybe we see after all the comments are addressed)

@fchinu fchinu changed the title [PWGHF] Add reduced workflow for B+, B0s -> J/Psi X analyses [Common, PWGHF] Add reduced workflow for B+, B0s -> J/Psi X analyses May 30, 2025
@github-actions github-actions bot changed the title [Common, PWGHF] Add reduced workflow for B+, B0s -> J/Psi X analyses [Common,PWGHF] Add reduced workflow for B+, B0s -> J/Psi X analyses May 30, 2025
@fchinu fchinu marked this pull request as ready for review June 3, 2025 12:29
@fchinu fchinu requested review from iarsene and jgrosseo as code owners June 3, 2025 12:29
@vkucera
Copy link
Collaborator

vkucera commented Jun 10, 2025

It seems that the MC matching is still using local enums and bitmaps instead of the enums from the main header.

@fgrosa
Copy link
Collaborator

fgrosa commented Jun 10, 2025

Hi @vkucera @fchinu sorry to comment only now, but the flags in the main header are not good as they are; all the flags for the channels with JPsi should be in the same enum (because one can be background for the other), and they should not be split between resonant and non resonant (unless for the Bs -> JPsi Phi you add a correspondent non resonant channel Bs -> JPsi KK, but I am not sure if it is necessary, since only the resonant should be relevant).

Also please add values in the enum only at the end, because if you add them in the middle, they shift all the other flags (fine now that they have been just introduced, but this has to be avoided because it can create a complete mess as soon as people start producing derived data with these flags). It is more important than keeping the mother particles grouped (even if not "nice" it is not error prone as adding values in the middle). Thanks!

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure to apply IWYU and sort the includes with the latest clang-format configuration.
Also please fix the linter errors related to your code.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for ee3a0d6 at 2025-06-12 14:05:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11368-slc9_x86-64/0/PWGHF/D2H/TableProducer/candidateCreatorBToJpsiReduced.cxx:422:32: error: 'const struct o2::soa::Table<o2::aod::Hash<1569943865>, o2::aod::Hash<1835387129>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1569943865>, o2::aod::Hash<1835387129>, o2::aod::Hash<2286545062> > >' has no member named 'jPsiId'; did you mean 'jpsiId'?
/sw/SOURCES/O2Physics/11368-slc9_x86-64/0/PWGHF/D2H/TableProducer/candidateCreatorBToJpsiReduced.cxx:422:50: error: 'const struct o2::soa::Table<o2::aod::Hash<1280749938>, o2::aod::Hash<2904433183>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1280749938>, o2::aod::Hash<2904433183>, o2::aod::Hash<2286545062> > >' has no member named 'jPsiId'; did you mean 'jpsiId'?
/sw/SOURCES/O2Physics/11368-slc9_x86-64/0/PWGHF/D2H/TableProducer/candidateCreatorBToJpsiReduced.cxx:434:32: error: 'const struct o2::soa::Table<o2::aod::Hash<2181558043>, o2::aod::Hash<3476839899>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<2181558043>, o2::aod::Hash<3476839899>, o2::aod::Hash<2286545062> > >' has no member named 'jPsiId'; did you mean 'jpsiId'?
/sw/SOURCES/O2Physics/11368-slc9_x86-64/0/PWGHF/D2H/TableProducer/candidateCreatorBToJpsiReduced.cxx:434:50: error: 'const struct o2::soa::Table<o2::aod::Hash<937710351>, o2::aod::Hash<888947742>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<937710351>, o2::aod::Hash<888947742>, o2::aod::Hash<2286545062> > >' has no member named 'jPsiId'; did you mean 'jpsiId'?
ninja: build stopped: subcommand failed.

Full log here.

@fchinu
Copy link
Contributor Author

fchinu commented Jun 13, 2025

@vkucera MegaLinter is failing but the headers are ordered as described in the documentation (i.e. C++ headers at the end). The latest .clang-format was used to get this ordering. Can we merge as it is?

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fchinu ! Looks good to me.

@ddobrigk ddobrigk enabled auto-merge (squash) June 13, 2025 12:55
@ddobrigk ddobrigk merged commit 84277d3 into AliceO2Group:master Jun 13, 2025
12 of 14 checks passed
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 18, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 20, 2025
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants