-
Notifications
You must be signed in to change notification settings - Fork 615
[Common,PWGHF] Add reduced workflow for B+, B0s -> J/Psi X analyses #11368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 29 errors, |
|
I would not feel super comfortable in fixing the O2 linter error |
That's OK. That error is unrelated to your code and PR. Thanks for fixing the rest. |
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fchinu thanks a lot for the developments! I have checked everything except for the tasks, since there are a few "major" things to change first I think.
For the tasks instead, we could even consider to have a combined one (but maybe we see after all the comments are addressed)
|
It seems that the MC matching is still using local enums and bitmaps instead of the enums from the main header. |
|
Hi @vkucera @fchinu sorry to comment only now, but the flags in the main header are not good as they are; all the flags for the channels with JPsi should be in the same enum (because one can be background for the other), and they should not be split between resonant and non resonant (unless for the Bs -> JPsi Phi you add a correspondent non resonant channel Bs -> JPsi KK, but I am not sure if it is necessary, since only the resonant should be relevant). Also please add values in the enum only at the end, because if you add them in the middle, they shift all the other flags (fine now that they have been just introduced, but this has to be avoided because it can create a complete mess as soon as people start producing derived data with these flags). It is more important than keeping the mother particles grouped (even if not "nice" it is not error prone as adding values in the middle). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also make sure to apply IWYU and sort the includes with the latest clang-format configuration.
Also please fix the linter errors related to your code.
|
Error while checking build/O2Physics/o2 for ee3a0d6 at 2025-06-12 14:05: Full log here. |
|
@vkucera |
vkucera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fchinu ! Looks good to me.
…liceO2Group#11368) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…liceO2Group#11368) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…liceO2Group#11368) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…liceO2Group#11368) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…liceO2Group#11368) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…liceO2Group#11368) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This PR adds the reduced workflows for the B+ and B0s meson analyses for their decays into a J/Psi and a K+ and phi, respectively. The considered decay of the J/Psi is that into a muon pair at midrapidity, and this workflow is meant to be used for the newly-developed HF software triggers for 2025 pp data taking. A
runJPsiToeeis also available in order to validate the workflow using the already existing MC simulations of B -> J/Psi X -> ee X.In a following PR the workflow of B0 -> J/psi K*(892)0 -> (µµ) (Kpi) will be added, following what was done for the B0s -> J/Psi phi -> (µµ)(KK) workflow.