[PWGHF] treeCreatorOmegacSt: Add new decay channel (Omega Kaon) and MC source flag #11356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengtt0406
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
vkucera
reviewed
May 26, 2025
Collaborator
|
Please fix the errors. |
vkucera
requested changes
May 27, 2025
Comment on lines
561
to
563
| std::array<double, 2> massesOmegacToOmegaPi{o2::constants::physics::MassOmegaMinus, o2::constants::physics::MassPiPlus}; | ||
| std::array<double, 2> massesOmegacToOmegaK{o2::constants::physics::MassOmegaMinus, o2::constants::physics::MassKPlus}; | ||
| std::array<double, 2> massesXicDaughters{o2::constants::physics::MassXiMinus, o2::constants::physics::MassPiPlus}; |
Collaborator
There was a problem hiding this comment.
Use NProngs or NDaughters wherever you create containers with elements related to the decay products.
Contributor
Author
There was a problem hiding this comment.
For this point, I would like to keep the current version. To keep consistent with the others in our code.
Collaborator
There was a problem hiding this comment.
The code is more understandable when the meaning is conveyed through the names of the entities. This is even more relevant in your case since you operate with 6 different arrays of masses which happen to all have 2 prongs.
Collaborator
There was a problem hiding this comment.
Please address it in the next PR.
vkucera
requested changes
May 30, 2025
vkucera
approved these changes
May 30, 2025
vkucera
changed the title
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 11, 2025
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Jun 11, 2025
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Jun 12, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 12, 2025
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jul 16, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.