Skip to content

[ALICE3] A3 OTF: add LUT maker with FastTracker #11341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 4 commits into from
May 27, 2025
Merged

[ALICE3] A3 OTF: add LUT maker with FastTracker #11341

njacazio merged 4 commits into from
May 27, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented May 23, 2025

No description provided.

@njacazio njacazio marked this pull request as ready for review May 23, 2025 15:55
@njacazio njacazio requested review from alibuild and hscheid as code owners May 23, 2025 15:55
@github-actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

O2 linter results: ❌ 70 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title A3 OTF: add LUT maker with FastTracker [ALICE3] A3 OTF: add LUT maker with FastTracker May 23, 2025
@njacazio njacazio enabled auto-merge (squash) May 23, 2025 15:56
@njacazio
Copy link
Collaborator Author

njacazio commented May 23, 2025

@jesgum @ddobrigk

alibuild
alibuild previously approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
Copy link
Collaborator Author

njacazio commented May 23, 2025

I was thinking that the user macros (mostly python scripts) could go in the separate repository for now

@alibuild
Copy link
Collaborator

alibuild commented May 24, 2025

Error while checking build/O2Physics/o2 for 4a207b0 at 2025-05-24 02:02:

## sw/BUILD/O2Physics-latest/log
/sw/BUILD/a2dace3e81e94c1c00d875a60a50412623824b57/O2Physics/ALICE3/Core/G__O2PhysicsFastTracker.cxx:252:7: error: deleting object of polymorphic class type 'o2::fastsim::DelphesO2LutWriter' which has non-virtual destructor might cause undefined behavior [-Werror=delete-non-virtual-dtor]
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio disabled auto-merge May 24, 2025 17:39
@njacazio njacazio enabled auto-merge (squash) May 24, 2025 17:39
alibuild
alibuild previously approved these changes May 24, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild
Copy link
Collaborator

alibuild commented May 24, 2025

Error while checking build/O2Physics/o2 for 9364ab1 at 2025-05-24 20:02:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 26, 2025

Error while checking build/O2Physics/o2 for 2814789 at 2025-05-26 22:54:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio disabled auto-merge May 27, 2025 10:43
@njacazio njacazio enabled auto-merge (squash) May 27, 2025 10:43
alibuild
alibuild approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit f6732b5 into AliceO2Group:master May 27, 2025
12 of 13 checks passed
@njacazio njacazio deleted the nj-a3lutmaker branch May 27, 2025 13:05
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@njacazio @jinhyunni
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
6e728bf
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
@njacazio @EmilGorm
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
159f3ec
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@njacazio
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
0e72edf
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@njacazio
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
2451510
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@njacazio @smaff92
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
471829f
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@njacazio @romainschotter
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
76fcd84
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@njacazio @CesarOmarRA
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
1b71178
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@njacazio @jloemker
[ALICE3] A3 OTF: add LUT maker with FastTracker (AliceO2Group#11341)
3f124f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njacazio @alibuild