[PWGCF] Add long range correlations analysis task #11329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

victor-gonzalez merged 8 commits into AliceO2Group:master from abmodak:gen-corr

May 23, 2025

Collaborator

abmodak commented May 23, 2025

No description provided.

abmodak added 2 commits

May 23, 2025 12:10


          Add files via upload

6a98d3a


          Update CMakeLists.txt

abmodak requested review from alibuild, ariedel-cern, glromane, lauraser, lgraczykCern, otonvd, prchakra, saganatt, shouqiye, victor-gonzalez and zchochul as code owners

May 23, 2025 10:13

github-actions bot added the pwgcf label

github-actions bot commented May 23, 2025 •

edited

Loading

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

github-actions bot changed the title ~~Add correlation analysis task~~ [PWGCF] Add correlation analysis task


          Fix o2 liner errors inside genCorr.cxx

340d5b6

victor-gonzalez requested changes

View reviewed changes

Collaborator

victor-gonzalez left a comment

Please, have a look at my comments

PWGCF/TwoParticleCorrelations/Tasks/CMakeLists.txt Outdated

    
                                         PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::AnalysisCore O2Physics::PWGCFCore

                                         COMPONENT_NAME Analysis)

              o2physics_add_dpl_workflow(gen-corr

Collaborator

victor-gonzalez May 23, 2025

Could the task name (and source file) be a bit more specific?
gen immediately addresses MC generator level which I guess it is not the aim
And corr is ambiguous having in mind the task is whithin the TwoParticleCorrelations directory
As it seems that the FT0 is being considered, what about something like long range correlations?

PWGCF/TwoParticleCorrelations/Tasks/genCorr.cxx Outdated

    
              // granted to it by virtue of its status as an Intergovernmental Organization

              // or submit itself to any jurisdiction.

              ///

              /// \file genCorr.cxx

Collaborator

victor-gonzalez May 23, 2025

See previous comment

PWGCF/TwoParticleCorrelations/Tasks/genCorr.cxx Outdated

    
              ///

              /// \file genCorr.cxx

              ///

              /// \brief task for correlation analysis

Collaborator

victor-gonzalez May 23, 2025

See previous comment

PWGCF/TwoParticleCorrelations/Tasks/genCorr.cxx Outdated

    
                struct : ConfigurableGroup {

                  Configurable<std::string> cfgURL{"cfgURL", "http://alice-ccdb.cern.ch", "Address of the CCDB to browse"};

                  Configurable<int64_t> noLaterThan{"ccdb-no-later-than", std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count(), "Latest acceptable timestamp of creation for the object"};

Collaborator

victor-gonzalez May 23, 2025

As this is a new task, please, adhere to the linter recommendations

PWGCF/TwoParticleCorrelations/Tasks/genCorr.cxx Outdated

    
                  ft0Det.calculateChannelCenter();

                  auto chPos = ft0Det.getChannelCenter(chno);

                  auto phi = std::atan2(chPos.Y() + offsetY, chPos.X() + offsetX);

                  if (phi < 0) {

Collaborator

victor-gonzalez May 23, 2025

It is safe here to also use the RecoDecay method

PWGCF/TwoParticleCorrelations/Tasks/genCorr.cxx Outdated

    
                      }

                      float deltaPhi = RecoDecay::constrainAngle(triggerTrack.phi() - phiA, -PIHalf);

                      float deltaEta = triggerTrack.eta() - etaA;

                      // LOGF(info, "delta eta = %f and delta phi = %f", deltaEta, deltaPhi);

Collaborator

victor-gonzalez May 23, 2025

Please, don't leave code commented


          Update and rename genCorr.cxx to longrangeCorrelation.cxx

7e9369e

alibuild mentioned this pull request

Please consider the following formatting changes to #11329 abmodak/O2Physics#5

Merged

abmodak and others added 3 commits

May 23, 2025 15:40


          Update CMakeLists.txt

06625f5


          Please consider the following formatting changes

27bc9fa


          Merge pull request #5 from alibuild/alibot-cleanup-11329

aca1029

Please consider the following formatting changes to AliceO2Group#11329

Collaborator Author

abmodak commented May 23, 2025

Hello @victor-gonzalez,
Thanks for your suggestions.
Your comments are now implemented.

Thanks,
Abhi


          Fix build/O2Physics/o2/macOS-arm error

3d194e9

Collaborator

alibuild commented May 23, 2025

Error while checking build/O2Physics/o2 for 340d5b6 at 2025-05-23 16:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11329-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/genCorr.cxx:238:29: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez changed the title ~~[PWGCF] Add correlation analysis task~~ [PWGCF] Add long range correlations analysis task

victor-gonzalez approved these changes

View reviewed changes

Collaborator

victor-gonzalez left a comment

Thanks!!

victor-gonzalez enabled auto-merge (squash)

May 23, 2025 20:30

victor-gonzalez merged commit d537962 into AliceO2Group:master

14 of 15 checks passed

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request


          [PWGCF] Add long range correlations analysis task (AliceO2Group#11329)

fe4bf4e

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request


          [PWGCF] Add long range correlations analysis task (AliceO2Group#11329)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request


          [PWGCF] Add long range correlations analysis task (AliceO2Group#11329)

9388f00

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request


          [PWGCF] Add long range correlations analysis task (AliceO2Group#11329)

edaa05d

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

abmodak deleted the gen-corr branch

July 28, 2025 11:16

alibuild added a commit to alibuild/O2Physics that referenced this pull request


          [PWGCF] Add long range correlations analysis task (AliceO2Group#11329)

e469775

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request


          [PWGCF] Add long range correlations analysis task (AliceO2Group#11329)

5d86575

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

victor-gonzalez victor-gonzalez approved these changes

alibuild Awaiting requested review from alibuild alibuild is a code owner

saganatt Awaiting requested review from saganatt

zchochul Awaiting requested review from zchochul zchochul is a code owner

lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

prchakra Awaiting requested review from prchakra prchakra is a code owner

lauraser Awaiting requested review from lauraser lauraser is a code owner

ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

otonvd Awaiting requested review from otonvd otonvd is a code owner

shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

glromane Awaiting requested review from glromane glromane is a code owner

Labels