Skip to content

[PWGCF] Added additional event selections and a preliminary V0 efficiency cal… #11313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JStaa wants to merge 0 commits into from
Closed

[PWGCF] Added additional event selections and a preliminary V0 efficiency cal… #11313

JStaa wants to merge 0 commits into from

Conversation

@JStaa
Copy link
Contributor

@JStaa JStaa commented May 22, 2025

…culation

@github-actions github-actions bot added the pwgcf label May 22, 2025
@github-actions
Copy link

github-actions bot commented May 22, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Added additional event selections and a preliminary V0 efficiency cal… [PWGCF] Added additional event selections and a preliminary V0 efficiency cal… May 22, 2025
@alibuild alibuild mentioned this pull request May 22, 2025
Merged
JStaa added a commit to JStaa/O2Physics that referenced this pull request May 22, 2025
@JStaa
Merge pull request #28 from alibuild/alibot-cleanup-11313
480283e 
[PWGCF] Please consider the following formatting changes to AliceO2Group#11313
@victor-gonzalez victor-gonzalez enabled auto-merge (squash) May 22, 2025 18:49
@alibuild
Copy link
Collaborator

alibuild commented May 22, 2025

Error while checking build/O2Physics/o2 for 4c033dc at 2025-05-22 23:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11313-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx:69:80: error: comparison of constant 'o2::aod::evsel::kNoSameBunchPileup' with boolean expression is always false [-Werror=bool-compare]
/sw/SOURCES/O2Physics/11313-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx:69:122: error: comparison of constant 'o2::aod::evsel::kIsGoodZvtxFT0vsPV' with boolean expression is always false [-Werror=bool-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 23, 2025

Error while checking build/O2Physics/o2 for 480283e at 2025-05-23 04:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11313-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx:69:80: error: comparison of constant 'o2::aod::evsel::kNoSameBunchPileup' with boolean expression is always false [-Werror=bool-compare]
/sw/SOURCES/O2Physics/11313-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/threeParticleCorrelations.cxx:69:122: error: comparison of constant 'o2::aod::evsel::kIsGoodZvtxFT0vsPV' with boolean expression is always false [-Werror=bool-compare]
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez
Copy link
Collaborator

victor-gonzalez commented May 23, 2025

I guess you would want to fix the compiler errors (they are significant!) before merging

auto-merge was automatically disabled May 23, 2025 09:30

Head branch was pushed to by a user without write access

@JStaa JStaa closed this May 23, 2025
auto-merge was automatically disabled May 23, 2025 09:30

Pull request was closed

@JStaa JStaa closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern

@prchakra prchakra Awaiting requested review from prchakra

@lauraser lauraser Awaiting requested review from lauraser

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern

@otonvd otonvd Awaiting requested review from otonvd

@shouqiye shouqiye Awaiting requested review from shouqiye

@glromane glromane Awaiting requested review from glromane

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JStaa @alibuild @victor-gonzalez