Skip to content

[PWGHF] align the table between reduced and not-reduced workflow for Lb #11279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangbiao-phy merged 12 commits into from
May 21, 2025
Merged

[PWGHF] align the table between reduced and not-reduced workflow for Lb #11279

zhangbiao-phy merged 12 commits into from
May 21, 2025

Conversation

@zhangbiao-phy
Copy link
Collaborator

@zhangbiao-phy zhangbiao-phy commented May 21, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 31 disabled

@alibuild alibuild mentioned this pull request May 21, 2025
Merged
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review May 21, 2025 09:04
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] align the table between reduced and not-reduced table for Lb [PWGHF] align the table between reduced and not-reduced workflow for Lb May 21, 2025
@alibuild
Copy link
Collaborator

alibuild commented May 21, 2025

Error while checking build/O2Physics/o2 for c01b3b3 at 2025-05-21 11:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11279-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorLb.cxx:256:43: error: unused parameter 'lcCandidates' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11279-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorLb.cxx:257:40: error: unused parameter 'tracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented May 21, 2025

Thanks @zhangbiao-phy

@zhangbiao-phy
Copy link
Collaborator Author

zhangbiao-phy commented May 21, 2025

Thanks @zhangbiao-phy

Thanks to you! if no further comments, I will approve it

@vkucera
Copy link
Collaborator

vkucera commented May 21, 2025

Thanks @zhangbiao-phy

Thanks to you! if no further comments, I will approve it

If you have tested it locally, go for it.

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) May 21, 2025 13:13
alibuild
alibuild approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@zhangbiao-phy zhangbiao-phy merged commit 8c4ba1d into AliceO2Group:master May 21, 2025
11 of 12 checks passed
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@zhangbiao-phy @alibuild @ariedel-cern
[PWGHF] align the table between reduced and not-reduced workflow for …
7c20755 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@zhangbiao-phy @alibuild @jinhyunni
[PWGHF] align the table between reduced and not-reduced workflow for …
c3c5e0f 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@zhangbiao-phy @alibuild
[PWGHF] align the table between reduced and not-reduced workflow for …
8a1f04a 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@zhangbiao-phy @alibuild
[PWGHF] align the table between reduced and not-reduced workflow for …
aad477a 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@zhangbiao-phy @alibuild @smaff92
[PWGHF] align the table between reduced and not-reduced workflow for …
706f883 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@zhangbiao-phy @alibuild @CesarOmarRA
[PWGHF] align the table between reduced and not-reduced workflow for …
03bb9e0 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@zhangbiao-phy @alibuild @jloemker
[PWGHF] align the table between reduced and not-reduced workflow for …
04455ef 
…Lb (AliceO2Group#11279)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangbiao-phy @alibuild @vkucera