Skip to content

Conversation

@Elros60
Copy link
Contributor

@Elros60 Elros60 commented May 17, 2025

  • Data model changed for realigned muons so they will take the same format as original fwdtrack tables with only necessary kinematics updated if requiring realignment. At DQ maker level, this new table will be treated in the same way as fwdtracks table.
  • Only fwdtrack_as has to be replaced by rawIteratorAt to make use of fwdtrackId in FwdTrackAssoc in case of realigned muons which is not bounded to FwdTrackAssoc table. The later operation is safe in the sense that realigned muons table preserves the row-by-row correspondance with the orignal fwdtracks table.

@github-actions
Copy link

github-actions bot commented May 17, 2025

O2 linter results: ❌ 748 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title [Common, PWGDQ] Optimising muon realignment code [Common,PWGDQ] Optimising muon realignment code May 17, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 22c6238 at 2025-05-17 21:27:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11235-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1495:82: error: no matching function for call to 'TableMaker::fullSkimming<gkEventFillMapWithCentAndMults, gkTrackFillMapNoTOF, 0, 0, 0>(const MyEventsWithCentAndMults&, const o2::aod::BCsWithTimestamps&, std::nullptr_t, const MyBarrelTracksWithCovNoTOF&, std::nullptr_t, std::nullptr_t, std::nullptr_t, const o2::aod::TrackAssoc&, std::nullptr_t, std::nullptr_t)'
ninja: build stopped: subcommand failed.

Full log here.

@Elros60
Copy link
Contributor Author

Elros60 commented May 17, 2025

Error while checking build/O2Physics/o2 for 22c6238 at 2025-05-17 21:27:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11235-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1495:82: error: no matching function for call to 'TableMaker::fullSkimming<gkEventFillMapWithCentAndMults, gkTrackFillMapNoTOF, 0, 0, 0>(const MyEventsWithCentAndMults&, const o2::aod::BCsWithTimestamps&, std::nullptr_t, const MyBarrelTracksWithCovNoTOF&, std::nullptr_t, std::nullptr_t, std::nullptr_t, const o2::aod::TrackAssoc&, std::nullptr_t, std::nullptr_t)'
ninja: build stopped: subcommand failed.

Full log here.

This building error still exists after my new commit; the above mentioned line doesn't even agree with changed file:

fullSkimming<gkEventFillMapWithCentAndMults, gkTrackFillMapWithV0Bits, 0u, 0u>(collisions, bcs, nullptr, tracksBarrel, nullptr, nullptr, trackAssocs, nullptr, nullptr);

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 0117984 at 2025-05-18 01:04:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11235-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1495:82: error: no matching function for call to 'TableMaker::fullSkimming<gkEventFillMapWithCentAndMults, gkTrackFillMapNoTOF, 0, 0, 0>(const MyEventsWithCentAndMults&, const o2::aod::BCsWithTimestamps&, std::nullptr_t, const MyBarrelTracksWithCovNoTOF&, std::nullptr_t, std::nullptr_t, std::nullptr_t, const o2::aod::TrackAssoc&, std::nullptr_t, std::nullptr_t)'
ninja: build stopped: subcommand failed.

Full log here.

@Elros60 Elros60 force-pushed the dev_RealignImprov branch from 0117984 to 1aae26d Compare May 19, 2025 10:08
@iarsene iarsene enabled auto-merge (squash) May 19, 2025 11:05
@iarsene iarsene merged commit 05920f0 into AliceO2Group:master May 19, 2025
12 of 14 checks passed
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants