Skip to content

[PWGCF] New PID cuts added #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
victor-gonzalez merged 23 commits into from
May 16, 2025
Merged

[PWGCF] New PID cuts added #11193

victor-gonzalez merged 23 commits into from
May 16, 2025

Conversation

@pravatp98
Copy link
Contributor

@pravatp98 pravatp98 commented May 14, 2025

New PID cuts added for improvisation

@github-actions github-actions bot added the pwgcf label May 14, 2025
@github-actions
Copy link

github-actions bot commented May 14, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title New PID cuts added [PWGCF] New PID cuts added May 14, 2025
@alibuild alibuild mentioned this pull request May 14, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented May 14, 2025

Error while checking build/O2Physics/o2 for 50be6e1 at 2025-05-14 17:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11193-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:759:23: error: 'NchCumulantsIdentified' was not declared in this scope; did you mean 'NchCumulantsId'?
/sw/SOURCES/O2Physics/11193-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:759:46: error: no matching function for call to 'adaptAnalysisTask<<expression error> >(const o2::framework::ConfigContext&)'
/sw/SOURCES/O2Physics/11193-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:759:46: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/11193-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:759:52: error: no matching function for call to 'std::vector<o2::framework::DataProcessorSpec>::vector(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez
Copy link
Collaborator

victor-gonzalez commented May 15, 2025

Please, fix the clang-format error

@pravatp98
Copy link
Contributor Author

pravatp98 commented May 16, 2025

Dear @victor-gonzalez kindly review the PR, where updated PID cuts has been added to the code. Waiting for your kind approval

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) May 16, 2025 18:21
@victor-gonzalez victor-gonzalez merged commit fe28fe2 into AliceO2Group:master May 16, 2025
13 of 14 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@pravatp98
[PWGCF] New PID cuts added (AliceO2Group#11193)
1726e63
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@pravatp98 @ariedel-cern
[PWGCF] New PID cuts added (AliceO2Group#11193)
e17fd64
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@pravatp98 @jinhyunni
[PWGCF] New PID cuts added (AliceO2Group#11193)
869ac57
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@pravatp98
[PWGCF] New PID cuts added (AliceO2Group#11193)
480fb23
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@pravatp98 @smaff92
[PWGCF] New PID cuts added (AliceO2Group#11193)
268eda4
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@pravatp98 @CesarOmarRA
[PWGCF] New PID cuts added (AliceO2Group#11193)
d9e70c0
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@pravatp98 @jloemker
[PWGCF] New PID cuts added (AliceO2Group#11193)
516c6dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pravatp98 @alibuild @victor-gonzalez