Skip to content

[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangbiao-phy merged 24 commits into from
May 16, 2025
Merged

[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

zhangbiao-phy merged 24 commits into from
May 16, 2025

Conversation

@zhangbiao-phy
Copy link
Collaborator

@zhangbiao-phy zhangbiao-phy commented May 14, 2025 •
edited
Loading

For convenience in doing the mixed event locally, I added the collision index to the table

  • Separate into 3 tables: charm, track, and collision
  • Add eta and phi into the table --> calculate k*, kT, mT locally
  • Remove table filling in the mix-event function (if the test is smooth, this part will be deleted later)

@github-actions
Copy link

github-actions bot commented May 14, 2025 •
edited
Loading

O2 linter results: ❌ 57 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title [PWGHF, PWGCF] add the collision index into the table [PWGHF,PWGCF] add the collision index into the table May 14, 2025
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review May 14, 2025 15:46
@alibuild alibuild mentioned this pull request May 15, 2025
Merged
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF,PWGCF] add the collision index into the table [PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task May 15, 2025
@alibuild alibuild mentioned this pull request May 15, 2025
Merged
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review May 15, 2025 16:43
@alibuild
Copy link
Collaborator

alibuild commented May 15, 2025

Error while checking build/O2Physics/o2 for 902f26d at 2025-05-15 19:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez
victor-gonzalez requested changes May 15, 2025
View reviewed changes
PWGCF/DataModel/FemtoDerived.h Outdated
fdhf::OriginMcRec);

DECLARE_SOA_TABLE(FDResultsHFTrkInfo, "AOD", "FDRESULTSHFTRKINFO", //! table to store results for HF femtoscopy
DECLARE_SOA_TABLE(FDResultsTrk, "AOD", "FDRESULTSTRK", //! table to store results for HF femtoscopy
Copy link
Collaborator

@victor-gonzalez victor-gonzalez May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep HF as before in the table declaration

Copy link
Collaborator Author

@zhangbiao-phy zhangbiao-phy May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Fixed

PWGCF/DataModel/FemtoDerived.h Outdated
femtodreamparticle::TPCNSigmaPr,
femtodreamparticle::TOFNSigmaPr);

DECLARE_SOA_TABLE(FDResultsColl, "AOD", "FDRESULTSCOLL", //! table to store results for HF femtoscopy
Copy link
Collaborator

@victor-gonzalez victor-gonzalez May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, incorporate HF in the table declaration

Copy link
Collaborator Author

@zhangbiao-phy zhangbiao-phy May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

vkucera
vkucera reviewed May 15, 2025
View reviewed changes
@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) May 16, 2025 07:56
alibuild
alibuild approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@zhangbiao-phy zhangbiao-phy merged commit 7d40bc8 into AliceO2Group:master May 16, 2025
12 of 13 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@zhangbiao-phy @alibuild
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
73c69a8 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@zhangbiao-phy @alibuild @ariedel-cern
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
2ed2e6d 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@zhangbiao-phy @alibuild @jinhyunni
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
3295838 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@zhangbiao-phy @alibuild
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
33fce90 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@zhangbiao-phy @alibuild @smaff92
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
ed020a4 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@zhangbiao-phy @alibuild @CesarOmarRA
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
e1e985d 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@zhangbiao-phy @alibuild @jloemker
[PWGHF,PWGCF] Split same-event table and add the collision infos into…
d8cea14 
… lcp femto task (AliceO2Group#11191)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild alibuild approved these changes

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangbiao-phy @alibuild @victor-gonzalez @vkucera