Skip to content

[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction #11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nzardosh merged 2 commits into from
May 14, 2025
Merged

[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction #11182

nzardosh merged 2 commits into from
May 14, 2025

Conversation

@hahassan7
Copy link
Collaborator

@hahassan7 hahassan7 commented May 13, 2025

A cut on the IPxy and IPz has been implemented to reject tracks with extremely large DCAs for training the ML model and also for the secondary vertex reconstruction.
I also implemented a compatibility with models that uses multi classification with softmax instead of just using binary classification with sigmoid.

@github-actions github-actions bot added the pwgje label May 13, 2025
@github-actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

O2 linter results: ❌ 94 errors, ⚠️ 0 warnings, 🔕 8 disabled

@alibuild
Copy link
Collaborator

alibuild commented May 13, 2025

Error while checking build/O2Physics/o2 for 9f7d13a at 2025-05-13 18:41:

## sw/BUILD/arrow-latest/log
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
ninja: build stopped: subcommand failed.

Full log here.

@nzardosh nzardosh enabled auto-merge (squash) May 14, 2025 10:18
@nzardosh nzardosh merged commit 7d6e3e4 into AliceO2Group:master May 14, 2025
12 of 13 checks passed
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request May 15, 2025
@hahassan7 @louisemillot
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
c209ee8 
…ceO2Group#11182)
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@hahassan7
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
fc05179 
…ceO2Group#11182)
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@hahassan7 @ariedel-cern
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
4393fc7 
…ceO2Group#11182)
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@hahassan7 @jinhyunni
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
5037737 
…ceO2Group#11182)
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@hahassan7
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
75246c9 
…ceO2Group#11182)
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@hahassan7 @smaff92
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
9a3a98f 
…ceO2Group#11182)
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@hahassan7 @CesarOmarRA
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
e042678 
…ceO2Group#11182)
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@hahassan7 @jloemker
[PWGJE] Adding a cut on IP for TreeCreator and SV reconstruction (Ali…
f421db8 
…ceO2Group#11182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hahassan7 @alibuild @nzardosh