Skip to content

Conversation

@abmodak
Copy link
Collaborator

@abmodak abmodak commented May 12, 2025

No description provided.

@abmodak abmodak requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners May 12, 2025 21:25
@github-actions
Copy link

github-actions bot commented May 12, 2025

O2 linter results: ❌ 2 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add PMD QA task [Common] Add PMD QA task May 12, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 33934b4 at 2025-05-13 20:33:

## sw/BUILD/arrow-latest/log
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
ninja: build stopped: subcommand failed.

Full log here.

@abmodak abmodak enabled auto-merge (squash) May 16, 2025 08:58
@ddobrigk
Copy link
Collaborator

Hi @abmodak , thanks a lot for working on this!

If I may: could you please place the table declarations in a .h file under Common/DataModel instead of inside the task cxx? It is important to keep data model declarations in separate file to make sure that any collaborator who wishes to use the same table layouts has easy access to those in general, and that's why this is in our guidelines. Thank you!

@abmodak
Copy link
Collaborator Author

abmodak commented May 16, 2025

Hi @ddobrigk,
I include the table declarations in a .h file under Common/DataModel and modify the .cxx task accordingly.
Please have a look if everything is fine with you.

Thanks,
Abhi

@abmodak abmodak merged commit 4423b96 into AliceO2Group:master May 19, 2025
11 of 12 checks passed
@abmodak abmodak deleted the pmdqa branch May 19, 2025 10:03
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants