Skip to content

[PWGHF] Add derived-data creator for D* -> D0 pi #11147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 10 commits into from
May 13, 2025
Merged

[PWGHF] Add derived-data creator for D* -> D0 pi #11147

vkucera merged 10 commits into from
May 13, 2025

Conversation

@Mingze129
Copy link
Contributor

@Mingze129 Mingze129 commented May 9, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented May 9, 2025 •
edited
Loading

O2 linter results: ❌ 4 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request May 9, 2025
Closed
@Mingze129 Mingze129 force-pushed the Dstar_derived_data branch 2 times, most recently from 0b225b4 to 59771ca Compare May 9, 2025 12:56
@Mingze129 Mingze129 force-pushed the Dstar_derived_data branch from 59771ca to 70f92ed Compare May 9, 2025 12:59
@vkucera vkucera changed the title [PWGHF] Add derived table creator for D* -> D0 pi [PWGHF] Add derived-data creator for D* -> D0 pi May 12, 2025
vkucera
vkucera requested changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mingze129 , overall looks good to me, thanks. Please see my comments for minor suggestions.

vkucera
vkucera reviewed May 12, 2025
View reviewed changes
vkucera
vkucera reviewed May 12, 2025
View reviewed changes
Mingze129 and others added 5 commits May 12, 2025 17:32
@Mingze129 @vkucera
Update PWGHF/TableProducer/derivedDataCreatorDstarToD0Pi.cxx
4c47015 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Mingze129 @vkucera
Update PWGHF/TableProducer/derivedDataCreatorDstarToD0Pi.cxx
cc1cd16 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Mingze129 @vkucera
Update PWGHF/DataModel/DerivedTables.h
b2271d6 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Mingze129 @vkucera
Update PWGHF/TableProducer/derivedDataCreatorDstarToD0Pi.cxx
3dacc2e 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Mingze129 @vkucera
Update PWGHF/TableProducer/derivedDataCreatorDstarToD0Pi.cxx
edb4835 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Mingze129 and others added 2 commits May 12, 2025 17:33
@Mingze129 @vkucera
Update PWGHF/DataModel/DerivedTables.h
1a1c85d 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Mingze129
Update DerivedTables.h
125b87a
@Mingze129 Mingze129 requested a review from vkucera May 12, 2025 15:43
@Mingze129
Copy link
Contributor Author

Mingze129 commented May 12, 2025

Hi @vkucera , Thank you for your detailed review.
I believe I have revised the code according to your suggestions. Please check it.

@alibuild
Copy link
Collaborator

alibuild commented May 12, 2025

Error while checking build/O2Physics/o2 for e70504d at 2025-05-12 21:25:

No log files found

Full log here.

vkucera
vkucera approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mingze129 for addressing my suggestions.

@vkucera vkucera enabled auto-merge (squash) May 12, 2025 20:25
@vkucera vkucera merged commit 0f6225e into AliceO2Group:master May 13, 2025
10 of 12 checks passed
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request May 14, 2025
@Mingze129 @vkucera @louisemillot
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
53cf6ff 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@Mingze129 @vkucera
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
94074ee 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@Mingze129 @vkucera @ariedel-cern
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
fda3f6f 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@Mingze129 @vkucera @jinhyunni
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
1c6c9d1 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@Mingze129 @vkucera
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
1733312 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@Mingze129 @vkucera @smaff92
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
2241ee2 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@Mingze129 Mingze129 deleted the Dstar_derived_data branch July 4, 2025 10:50
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@Mingze129 @vkucera @CesarOmarRA
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
361c24a 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Mingze129 @vkucera @jloemker
[PWGHF] Add derived-data creator for D* -> D0 pi (AliceO2Group#11147)
b74822a 
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mingze129 @alibuild @vkucera