Skip to content

[PWGCF] remove obsolete histogram #11094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
victor-gonzalez merged 10 commits into from
May 5, 2025
Merged

[PWGCF] remove obsolete histogram #11094

victor-gonzalez merged 10 commits into from
May 5, 2025

Conversation

@hernasab
Copy link
Contributor

@hernasab hernasab commented May 5, 2025

No description provided.

@github-actions github-actions bot added the pwgcf label May 5, 2025
@github-actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title remove obsolete histogram [PWGCF] remove obsolete histogram May 5, 2025
@alibuild
Copy link
Collaborator

alibuild commented May 5, 2025

Error while checking build/O2Physics/o2 for b2f7f32 at 2025-05-05 20:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:628:11: error: variable 'tZDCdif' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:629:11: error: variable 'tZDCsum' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 5, 2025

Error while checking build/O2Physics/o2 for dbadf29 at 2025-05-05 20:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:658:7: error: 'tZDCdif' was not declared in this scope
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:659:7: error: 'tZDCsum' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 5, 2025

Error while checking build/O2Physics/o2 for 30df400 at 2025-05-05 20:33:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:624:11: error: variable 'tZNA' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:625:11: error: variable 'tZNC' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:626:11: error: variable 'tZPA' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11094-slc9_x86-64/0/PWGCF/Flow/Tasks/flowZdcTask.cxx:627:11: error: variable 'tZPC' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

@hernasab hernasab closed this May 5, 2025
@hernasab hernasab reopened this May 5, 2025
@victor-gonzalez
Copy link
Collaborator

victor-gonzalez commented May 5, 2025

Please, make sure that a PR is made with free of warnings/errors locally compiled and tested code

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) May 5, 2025 20:55
@victor-gonzalez victor-gonzalez merged commit b3a22e9 into AliceO2Group:master May 5, 2025
22 of 23 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@hernasab @jinhyunni
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
fce2e84 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@hernasab @jinhyunni
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
d275527 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@hernasab
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
44ac4bd 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@hernasab @ariedel-cern
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
f6025e5 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@hernasab
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
905c32e 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@hernasab @smaff92
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
48c7d51 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@hernasab @CesarOmarRA
[PWGCF] remove obsolete histogram (AliceO2Group#11094)
bce3e4b 
Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hernasab @alibuild @victor-gonzalez