-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGHF] Reduce code duplication in the treeCreatorLcToPKPi #11016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 0 errors, |
This reverts commit 2ff1e90.
Hi @mfaggin, yes, it's fine with me to wait until another PR is merged. |
|
Hi @mfaggin, |
|
As long as you don't modify the commits merged from upstream, they will not appear in your PR. |
mfaggin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lubynets , approved
Such common parts as:
Lite,FullandKFtables;used both an
MCandDataoriented functions were encapsulated in separate functions.The
treeCreatorLcToPKPi's output was checked before and after the PR changes in the following conditions:MCandData;DCAFitterandKFParticle;LiteandFulltable. In all 2×2×2=8 cases there was the byte-to-byte size match of produced AnalysisResults_trees.root files before and after PR.