Skip to content

[PWGDQ] Process using realigned muon track in table-maker-mc-with-assoc #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ppoava wants to merge 1 commit into from
Closed

[PWGDQ] Process using realigned muon track in table-maker-mc-with-assoc #11010

ppoava wants to merge 1 commit into from

Conversation

@ppoava
Copy link
Contributor

@ppoava ppoava commented Apr 28, 2025

  1. This follows the previous 826faec which implemented a process in standard table-maker using realigned muon tracks; the same implementation is now made for table-maker-mc-with-assoc.
  2. Two new process(pp and PbPb) are added into table-maker-mc-with-assoc using realigned muons.

@github-actions github-actions bot added the pwgdq label Apr 28, 2025
@github-actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

O2 linter results: ❌ 86 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Apr 28, 2025
Closed
@ppoava ppoava marked this pull request as ready for review April 28, 2025 16:01
@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) April 29, 2025 07:50
@alibuild
Copy link
Collaborator

alibuild commented Apr 29, 2025

Error while checking build/O2Physics/o2 for 1d33a2c at 2025-04-29 10:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1472:2: error: expected '}' at end of input
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1408:3: error: a function-definition is not allowed here before '{' token
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1415:3: error: a function-definition is not allowed here before '{' token
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1422:3: error: a function-definition is not allowed here before '{' token
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1430:3: error: a function-definition is not allowed here before '{' token
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1438:3: error: a function-definition is not allowed here before '{' token
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1444:3: error: a function-definition is not allowed here before '{' token
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1458:32: error: 'processPbPb' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1458:32: error: 'processPbPb' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1458:32: error: 'processPbPb' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1459:32: error: 'processPbPbBarrelOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1459:32: error: 'processPbPbBarrelOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1459:32: error: 'processPbPbBarrelOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1460:32: error: 'processPbPbWithFilterBarrelOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1460:32: error: 'processPbPbWithFilterBarrelOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1460:32: error: 'processPbPbWithFilterBarrelOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1461:32: error: 'processPbPbMuonOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1461:32: error: 'processPbPbMuonOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1461:32: error: 'processPbPbMuonOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1462:32: error: 'processPbPbRealignedMuonOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1462:32: error: 'processPbPbRealignedMuonOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1462:32: error: 'processPbPbRealignedMuonOnly' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1463:32: error: 'processOnlyBCs' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1463:32: error: 'processOnlyBCs' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1463:32: error: 'processOnlyBCs' is not a member of 'TableMakerMC'
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1398:89: error: unused parameter 'muonsRealign' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1472:2: error: expected unqualified-id at end of input
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled April 29, 2025 14:45

Head branch was pushed to by a user without write access

@ppoava
Copy link
Contributor Author

ppoava commented May 5, 2025

Hey Luca, previously there was a small bug which hindered the compilation. Everything should be OK now, could you check the PR again? Best, Paul.

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) May 5, 2025 07:43
@lucamicheletti93 lucamicheletti93 disabled auto-merge May 5, 2025 07:43
@alibuild
Copy link
Collaborator

alibuild commented May 5, 2025

Error while checking build/O2Physics/o2 for 980e3dd at 2025-05-05 10:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1398:89: error: unused parameter 'muonsRealign' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11010-slc9_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1436:91: error: unused parameter 'muonsRealign' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) May 5, 2025 15:30
@lucamicheletti93 lucamicheletti93 disabled auto-merge May 6, 2025 10:06
@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) May 6, 2025 10:06
auto-merge was automatically disabled May 6, 2025 12:43

Head branch was pushed to by a user without write access

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) May 7, 2025 06:44
auto-merge was automatically disabled May 13, 2025 11:39

Head branch was pushed to by a user without write access

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) May 13, 2025 11:48
auto-merge was automatically disabled May 13, 2025 13:18

Head branch was pushed to by a user without write access

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) May 13, 2025 14:09
@alibuild
Copy link
Collaborator

alibuild commented May 13, 2025

Error while checking build/O2Physics/o2 for a41f6bd at 2025-05-13 18:34:

## sw/BUILD/arrow-latest/log
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled May 14, 2025 11:13

Head branch was pushed to by a user without write access

@ppoava ppoava force-pushed the dev_TableMakerMC_correct branch from a41f6bd to ac8d9c4 Compare May 14, 2025 11:13
@ppoava
[PWGDQ] Process using realigned muon track in table-maker-mc-with-assoc
874696f 
1. This follows the previous 826faec which implemented a process in standard table-maker using realigned muon tracks; the same implementation is now made for table-maker-mc-with-assoc.
2. Two new process(pp and PbPb) are added into table-maker-mc-with-assoc using realigned muons.
@ppoava ppoava force-pushed the dev_TableMakerMC_correct branch from ac8d9c4 to 874696f Compare May 14, 2025 11:13
@ppoava ppoava closed this May 14, 2025
@ppoava ppoava deleted the dev_TableMakerMC_correct branch May 25, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucamicheletti93 lucamicheletti93 lucamicheletti93 approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat

@feisenhu feisenhu Awaiting requested review from feisenhu

Assignees

No one assigned

Labels

pwgdq

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ppoava @alibuild @lucamicheletti93