[PWGJE,EMCAL-670] Update BC selection to EMCal QA task #10991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mhemmer-cern
commented
Apr 25, 2025
mhemmer-cern
commented
- removed rejection flags unique to collisions from BC selection
- updated sel8 definition from Run2 definition to Run 3 definition
- fixed setting of bitmask for sel8 to be set when BC fails sel8 selection, was the other way around before
mhemmer-cern
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa and
nzardosh
as code owners
|
O2 linter results: ❌ 0 errors, |
- removed rejection flags unique to collisions from BC selection - updated sel8 definition from Run2 definition to Run 3 definition - fixed setting of bitmask for sel8 to be set when BC fails sel8 selection, was the other way around before
fjonasALICE
approved these changes
Apr 25, 2025
ppoava
pushed a commit
to ppoava/O2Physics
that referenced
this pull request
Apr 28, 2025
mfaggin
pushed a commit
to mfaggin/O2Physics
that referenced
this pull request
Apr 30, 2025
bghanley1995
pushed a commit
to bghanley1995/O2Physics
that referenced
this pull request
May 5, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
May 11, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
May 11, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
May 17, 2025
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.