-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGHF] Add Lb reduced workflow into the framework #10978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 1 errors, |
Please consider the following formatting changes to AliceO2Group#10978
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhangbiao-phy, many thanks for the huge work! I have a few comments, some of them minor, others easy to implement but relevant
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
|
hi @vkucera, could you please take a look this PR? |
Hi @zhangbiao-phy , I am waiting for your replies. |
hi @vkucera, I believe I’ve replied to you everywhere. If you’re referring the only one place related to the conflict with the prongId, I also pinged you about it somewhere. |
vkucera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me, provided that there will soon be a PR unifying the reduced and not-reduced workflows and adjusting the Lb data model to match the table columns used for the other beauty particles.
|
|
||
| using HfRedPidDaus = soa::Join<aod::HfCand3ProngWPid, aod::HfRedPidDau0s_000, aod::HfRedPidDau1s_000, aod::HfRedPidDau2s_000>; | ||
|
|
||
| void process(HfRedPidDaus::iterator const& hfCandPidProngs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a process function for charm 2 prongs (otherwise currently it breaks for the B- -> D0 pi-)
| template <typename T1, typename T2, typename T3> | ||
| bool selectionLbToLcPiTopol(const T1& candLb, const T2& cuts, const T3& binsPt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be in principle used in the non-reduced version of the Lb selector (https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/TableProducer/candidateSelectorLbToLcPi.cxx), as it is for the other B hadrons in order to have a common code for the selection. I would anyway suggest to implement it in the candidateSelectorLbToLcPi.cxx in a second PR since this one is already very long
|
Error while checking build/O2Physics/o2 for 4a97f56 at 2025-05-08 14:06: Full log here. |
|
Error while checking build/O2Physics/o2 for 6dcf700 at 2025-05-08 14:37: Full log here. |
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
As discussed during the QM with @fgrosa and @mvolkl, we would like to add the reduced workflow of Lb into the framework. The workflow fellow with the B-hadrons already in the framework:
add Lb to Lc(pkpi)pi channel in dataCreatorCharmHadPiReduced.cxx
Reduced workflow:
simple converter for new tables: converterReducedHadronDausPid.cxx